-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes air alarms tolerate tiny amounts of phoron #6035
Makes air alarms tolerate tiny amounts of phoron #6035
Conversation
Anyone know why it keeps adding old commits when I make new branches? |
d79a505
to
2bf649c
Compare
So, personally, the way I would do it is not to give it a phoron-specific 0.25 thing but make it so that there's some epsilon of tolerance--i.e. if it says "0", it actually means "allow up to 0.001 moles", which should generally be fine. More universal than just the phoron thing, too. |
That'd be nice, but I don't know how to do that. Phoron is currently the only gas that's set to 0 for its min1, so it's not a problem for any other gas |
Could we get this un-TMed so that we can make sure #6037 works for our intended purposes without it? |
#6037 was tested locally, but I also took this one from the TM list, so you are free to test it on the server next round (due to the values I used you need to scrubb the atmosphere for a bit, to get below the threshold) but it should get out of warning level within less than 10 minutes when using a portable scrubber) |
Having to wait 10 minutes for a room to not freak out after a Vox crew member exists in it isn't really going to solve the issue this is intended to solve, then. |
About The Pull Request
Sets the max1 threshold for phoron to 0.25, making air alarms not freak out at the tiniest amount of the gas
Why It's Good For The Game
Vox breathing and solved air crises won't permanently make a room orange atmos alert
Changelog
🆑
fix: Air Alarms no longer freak out at infinitesimally small amounts of phoron
/:cl: