Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade2latest #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

matschundbrei
Copy link

-added readme
-bumped version to most current release
-fixed dependency to consul-cli

Ty for sharing this!
Cheers,
Jan

Copy link

@abohne abohne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the Release number

@@ -1,13 +1,13 @@
Name: vault
Version: 0.1.2
Version: 0.6.1
Release: 3%{?dist}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be reset to 1?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 as in "1%{?dist}" on line 3?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I am really not an expert on SPEC Files, would you mind explaining what any number means before the percent sign?

(will update the request on monday, have the stuff on my work computer)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I've found it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants