Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static-libs installation #1100

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

driverxdw
Copy link
Contributor

add static library installation in CMakeLists.txt of libclamav submodules

Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change makes sense to me and I can see this being useful if you want to statically link libclamav (and submodules) with some other program.

I'm running it through the test pipelines now.

@micahsnyder
Copy link
Contributor

Manual testing on Linux looks good:

❯ ls -la install/lib/
total 42252
drwxr-xr-x 3 micah micah     4096 Nov 27 10:36 ./
drwxr-xr-x 8 micah micah     4096 Nov 27 10:36 ../
-rw-r--r-- 1 micah micah 38642020 Nov 27 10:36 libclamav_rust.a
-rw-r--r-- 1 micah micah  3696484 Nov 27 10:36 libclamav_static.a
-rw-r--r-- 1 micah micah   145808 Nov 27 10:35 libclammspack_static.a
-rw-r--r-- 1 micah micah    16110 Nov 27 10:35 libclamunrar_iface_static.a
-rw-r--r-- 1 micah micah   633086 Nov 27 10:35 libclamunrar_static.a
-rw-r--r-- 1 micah micah   108684 Nov 27 10:36 libfreshclam_static.a
drwxr-xr-x 2 micah micah     4096 Nov 27 10:36 pkgconfig/

Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the windows static build fails without these suggested changes.

libclammspack/CMakeLists.txt Outdated Show resolved Hide resolved
libclamunrar/CMakeLists.txt Outdated Show resolved Hide resolved
libclamunrar_iface/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor Author

@driverxdw driverxdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed it, thank you for your suggestion!

Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@micahsnyder micahsnyder merged commit 63fa9b4 into Cisco-Talos:main Nov 30, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants