Fix possible memory leak if memory reallocation fails

In clamav-milter's `allow_list.c` `cli_regex2suffix`, if the realloc fails it's possible the original memory may not be free'd. Fixes: #1092
Cisco-Talos · Dec 1, 2023 · 6adc758 · 6adc758
1 parent dbc6ffe
commit 6adc758
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/clamav-milter/allow_list.c b/clamav-milter/allow_list.c
@@ -156,13 +156,15 @@ int smtpauth_init(const char *r)
             }
             if (len <= 0) continue;
             if (len * 3 + 1 > rxavail) {
-                ptr   = regex;
-                regex = realloc(regex, rxsize + 2048);
-                if (!regex) {
+                ptr        = regex;
+                char *temp = realloc(regex, rxsize + 2048);
+                if (!temp) {
+                    free(regex);
                     logg(LOGG_ERROR, "Cannot allocate memory for SkipAuthenticated file\n");
                     fclose(f);
                     return 1;
                 }
+                regex   = temp;
                 rxavail = 2048;
                 rxsize += 2048;
                 if (!ptr) {