Clambc compiler 1.4.0 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I used ubuntu:23.04 for easy access to clang-16, rather than figuring out the minimal way to install it using LLVM's packages. |
rsundriyal
reviewed
Mar 21, 2024
|
If we change the version of docker ubuntu base from 20.04 to (22.04,23.04, we might need to change it in Jenkinsfile for unstable pipeline too. Here -> File |
|
@rsundriyal Fixed |
val-ms
force-pushed
the
clambc-compiler-1.3.0
branch
from
70338aa to
3c9a622
Compare
|
I've updated this PR to assume the version number for the compiler release will be 1.4.0 instead, as per discussion. |
ragusaa
reviewed
May 21, 2024
| @@ -19,15 +19,13 @@ RUN apt-get update -y && \ | |||
| binutils \ | |||
| git \ | |||
| python3 \ | |||
| python3-distutils \ | |||
| python3-pip \ | |||
There was a problem hiding this comment.
I don't understand why, but removing the python3-pip gives me warnings that pytest is not installed.
ragusaa
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker image update for Cisco-Talos/clamav-bytecode-compiler#48