Add documentation in the driver for each opt pass, and remove unused passes #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val-ms
force-pushed
the
driver-inline-opt-pass-docs-and-remove-unused-passes
branch
3 times, most recently
from
4497ac8 to
f7f2d81
Compare
val-ms
commented
Aug 5, 2024
val-ms
force-pushed
the
driver-inline-opt-pass-docs-and-remove-unused-passes
branch
from
c23a29f to
2f1a92c
Compare
|
Force-pushed to squish the review changes into the first commit. |
ragusaa
approved these changes
Aug 6, 2024
Remove ClamBCChangeMallocArgSize and ClamBCRemoveUndefs. Also removed a commented out call to clambc-remove-pointer-phis. This pass is performed later on.
val-ms
force-pushed
the
driver-inline-opt-pass-docs-and-remove-unused-passes
branch
from
2f1a92c to
04e2acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a couple TODO's that I need help with:
Note: I didn't remove the Final version of the Lowering pass because I felt like that would require merging the NF version into the Lowering class, and maybe dispensing with the
isFinal()method. I wasn't really comfortable doing that in this commit which is supposed to be non-functional documentation/dead code stuff...