Remove unused global __Copyright #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused globals are causing warnings in the runtime due to the list indices getting out of sync in the list of Globals and ConstantExprs. This PR stores the copyright statement as metadata, so there is no unused global inserted into the runtime.
ragusaa
force-pushed
the
CLAM-2195-RemoveUnusedCopyrightVariable
branch
from
a1e2a51 to
0c8827d
Compare
|
Hey @ragusaa Just realized this PR is really stale. Was it waiting for my review? |
|
I think it was, I must have forgotten to ask about it (obviously). Let's just close it and get it done with the clang 16 upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused globals are causing warnings in the runtime due to the list indices getting out of sync in the list of Globals and ConstantExprs. This PR stores the copyright statement as metadata, so there is no unused global inserted into the runtime.