This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Add multiple function select in UploadAll dialog #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demonduck
reviewed
May 10, 2017
There was a problem hiding this comment.
Thanks for the great additions. There seems to be a new bug introduced by this pull request. Also please fork the dev branch and complete a pull request to the dev branch. That way we can ensure the master is a stable branch and the dev can have a test period before moving it to the master branch.
| return | ||
|
|
||
| msg = '[1st] Error: {}'.format(data['msg']) | ||
| msg = '[1st] Error: {}'.format(result['msg']) |
There was a problem hiding this comment.
This will cause an exception to occur, result is not a variable in the scope of __data. I believe the original master and dev branch correctly checks.
Pull fixes from original branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Added some basic code for selecting a function in the upload dialog and holding shift to select or deselect multiple functions.
Regards,
Jelle Vergeer