Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new infiltration module #147

Draft
wants to merge 60 commits into
base: develop
Choose a base branch
from
Draft

Commits on Jul 19, 2024

  1. Configuration menu
    Copy the full SHA
    5559836 View commit details
    Browse the repository at this point in the history
  2. Created files for a new infiltration routine to include all seasons a…

    …nd no just snow-covered
    djmallum committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8b8de72 View commit details
    Browse the repository at this point in the history
  3. Changed names of the infiltration routine to be more consistent, also…

    … started working on implementation of the full suite of processes
    djmallum committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    30cff21 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    98687eb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d6a1399 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f6e31b8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8df38cf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9f74eb0 View commit details
    Browse the repository at this point in the history
  9. editted rebase workflow

    djmallum committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c4b92d4 View commit details
    Browse the repository at this point in the history
  10. fixed typo in workflow

    djmallum committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ecdb364 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    69e892e View commit details
    Browse the repository at this point in the history
  12. changed checkout version

    djmallum committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    885abf7 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Configuration menu
    Copy the full SHA
    0df6a80 View commit details
    Browse the repository at this point in the history
  2. Created files for a new infiltration routine to include all seasons a…

    …nd no just snow-covered
    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    df34954 View commit details
    Browse the repository at this point in the history
  3. Changed names of the infiltration routine to be more consistent, also…

    … started working on implementation of the full suite of processes
    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6b28ae6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    875faff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d328114 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1e0a8c2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f9ee08d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a492f1c View commit details
    Browse the repository at this point in the history
  9. editted rebase workflow

    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d293e5b View commit details
    Browse the repository at this point in the history
  10. fixed typo in workflow

    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    735dc09 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1d64a5a View commit details
    Browse the repository at this point in the history
  12. changed checkout version

    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ee46645 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    59ed1fc View commit details
    Browse the repository at this point in the history
  14. A lot of changes here, too many for one commit, major theme is just m…

    …aking things closer to complete. From here on out, I'll try to make commits more discrete
    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    776b7e6 View commit details
    Browse the repository at this point in the history
  15. replaced crackstatus - crhm variable to count major melts - with more…

    … obvious variable name: major_melt_count. Also changed Major to lowercase, which is consistent with other syntax. Xinfil is also replaced. Was a 3 element vector storing, the Gray infiltration index, SWE from when the first major melt begins (init_SWE), and the maximum melt per day for a major melt (max_major_per_day)
    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    da46cff View commit details
    Browse the repository at this point in the history
  16. Added a long comment before the crack module (Gray 1985) pointing out…

    … some major issues with implementing this routine in CHM and a suggested fix. Also fixed a few typos.
    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4db5e6e View commit details
    Browse the repository at this point in the history
  17. Progress on finishing, added several variables to the header, and swi…

    …tched some variables from being per-trangle to global for the module. Also tried working on some functions for the crack routine but ran into issues, solve tomorrow
    allumhome authored and djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    44db1b3 View commit details
    Browse the repository at this point in the history
  18. Finished the part of the module copied from the CRHM module crack. Th…

    …is was moduled after the python version of this module I created in ClassGray.py found at: https://github.com/djmallum/PythonScripts/tree/main/HydrologyTestScripts
    allumhome authored and djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    158e716 View commit details
    Browse the repository at this point in the history
  19. Finished setting up Ayers part of this module, halfway through Green-…

    …Ampt
    allumhome authored and djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    86a3715 View commit details
    Browse the repository at this point in the history
  20. unique ptr added to the data subclass for easier function handling an…

    …d readability. Main body of GreenAmpt routine completed.
    allumhome authored and djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8846fd6 View commit details
    Browse the repository at this point in the history
  21. Complete Infil_All module

    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8c77475 View commit details
    Browse the repository at this point in the history
  22. Complete Infil_All.hpp header

    Function declarations, variables declarations up to date
    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0ac3e20 View commit details
    Browse the repository at this point in the history
  23. reset the workflow file and .gitignore to how it is written on the ma…

    …in repo. I changed these locally, but not necessary to merge with main repo.
    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    67ca0be View commit details
    Browse the repository at this point in the history
  24. Merge remote-tracking branch 'old-repo/develop' into develop

    This merge is taking my old repo, which is a detached fork to this new
    repo which is still attached to the main CHM repo.
    djmallum committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    59c1eb8 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    4ada4d3 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    a0227bd View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    6303a66 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Revert "changed checkout version"

    This reverts commit 885abf7.
    djmallum committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b7c59e9 View commit details
    Browse the repository at this point in the history
  2. Revert "switched to using GITHUB_TOKEN"

    This reverts commit 69e892e.
    djmallum committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    83cc60a View commit details
    Browse the repository at this point in the history
  3. Revert "fixed typo in workflow"

    This reverts commit ecdb364.
    djmallum committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    17cc8b3 View commit details
    Browse the repository at this point in the history
  4. Revert "editted rebase workflow"

    This reverts commit c4b92d4.
    djmallum committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    42ba3d4 View commit details
    Browse the repository at this point in the history
  5. Revert "Commented out broken workflow"

    This reverts commit 9f74eb0.
    djmallum committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8b23298 View commit details
    Browse the repository at this point in the history
  6. Revert "added rebasing to develop branch workflow"

    This reverts commit 8df38cf.
    djmallum committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7486093 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cb7735a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Fixed compiler errors

    djmallum committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c882a7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1428290 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a4a1c67 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b95dc6a View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Added soil storage continuation between time steps

    Currently there is no soil module in CHM. As a result, soil storage is
    handled completely by the Infil_All module by increasing d.soil_storage
    by d.GA_temp->final_storage in the GreenAmpt routine. The crack/Gray
    module does not use soil_storage in its calculation.
    
    When a soil module is added, this will have to be changed so that th
    efinal storage is sent to the soil module and taken as an input.
    djmallum committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c8a557e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Created a class in the Soil namespace

    Class contains methods for accessing static arrays which are used by
    infiltration module, Infil_All and the ET model PenmanMonteith.
    djmallum committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a29b97d View commit details
    Browse the repository at this point in the history
  2. Infil_All soil properties now external

    stored in physics/soil.h so that it can also be accessed by other
    routines.
    djmallum committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f29d3bb View commit details
    Browse the repository at this point in the history
  3. Merge branch 'develop' of https://github.com/djmallum/CHM into develop

    This repo only exists becuase it is directly tied to Chris Marsh' CHM
    repo and is used for merging and PRs.
    djmallum committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    847b23b View commit details
    Browse the repository at this point in the history
  4. Fixed Soil header typos

    djmallum committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4104684 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    32da0e3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    593ff05 View commit details
    Browse the repository at this point in the history
  7. added missing include

    djmallum committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fba73c8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    05c6046 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    670f9cc View commit details
    Browse the repository at this point in the history