Feature 1

.github/workflows/main.yml

@@ -17,12 +17,7 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
-      - name: Cache SonarQube packages
-        uses: actions/cache@v1
-        with:
-          path: ~\sonar\cache
-          key: ${{ runner.os }}-sonar
-          restore-keys: ${{ runner.os }}-sonar
+
       - name: Cache SonarQube scanner
         id: cache-sonar-scanner
         uses: actions/cache@v1
@@ -43,4 +38,4 @@ jobs:
         run: |
           .\.sonar\scanner\dotnet-sonarscanner begin /k:"christophe-havard-sonarsource_Github_Actions_DotNetCore" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="${{ secrets.SONAR_HOST_URL }}"
           dotnet build
-          .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}"
+          .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}"

Helper.cs

@@ -6,7 +6,7 @@
 namespace Surfrider {
 
 public static class Helper {
-    // https://docs.microsoft.com/en-us/azure/key-vault/secrets/quick-create-net
+
         private static string GetKeyVaultConnectionString(string secretName)
         {
 
@@ -20,14 +20,36 @@ private static string GetKeyVaultConnectionString(string secretName)
         }
         public static string GetConnectionString()
         {
-            if (Environment.GetEnvironmentVariable("AZURE_FUNCTIONS_ENVIRONMENT") != "Local")
-                return GetKeyVaultConnectionString("db-plastico-dev-connectionstring");
-            else
+
                 return Environment.GetEnvironmentVariable("postgre_connection");
         }
         // I add another useless code line
         public static void DoNothing(){
             Environment.GetEnvironmentVariable("postgre_connection");
+            int i = 0;
+            while(i< 100){
+                // toto
+            }
         }
+        public static int ComputeWithSomeRecursion(int num, int inc)
+        {
+            num = num * ComputeWithSomeRecursion(num, inc-1);
+            for(int i = 10; i < 10; i++){}
+            return 2*num;
+        }
+        public static void DoNothingAgain(){
+           // https://rules.sonarsource.com/csharp/type/Bug/RSPEC-3984
+            int x = -1;
+            if (x < 0)
+            {
+                new ArgumentException("x must be nonnegative");
+            }
+
+            Environment.GetEnvironmentVariable("postgre_connection");
+            int i = 0;
+            while(i< 100){
+                // toto
+            }
+        }
+}
 }
-}