-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Reports fields rename (M2-8268) #2002
base: develop
Are you sure you want to change the base?
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling eslint and TS
expect( | ||
getJourneyCSVObject({ | ||
...getPreparedProperties({ | ||
//eslint-disable-next-line @typescript-eslint/ban-ts-comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for disabling the eslint and TS here ?
Why is it necessary?
Is there a way to make it work without forcing the bypass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replicates pre-existing behavior for tests. The effort required to make the corresponding updates to remove these comments exceeds this ticket's scope. We could explore the option of making the corresponding updates to these tests at a later stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the comment to disable Ts and eslint the code looks good for me.
fix
orfeature
branches intodevelop
orrelease
branches viaSquash and Merge
(to keep clean history)📝 Description
🔗 Jira Ticket M2-8268
Renaming & reordering for both
report.csv
andactivity_user_journey.csv
fields. Also, renamedreport.csv
toresponses.csv
.All these changes were added behind a workspace-wide feature flag, so won't be directly enabled by default.
Current expected columns & order (for
report.csv
)New expected columns & order
The changes get propagated to
activity_user_journey.csv
. Additional fields for said report were left unchanged.🪤 Peer Testing
In order to test functionality, set
enableDataExportRenaming
feature flag totrue
.✏️ Notes
Something to keep in mind is that changes to subscales will come in a separate ticket, under the same feature flag that was used for all the changes added here