Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Constrain Take Now to availability schedule (M2-7180) #1868

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feature: Constrain Take Now to availability schedule (M2-7180) #1868

wants to merge 9 commits into from

Conversation

ionyRojas
Copy link
Contributor

@ionyRojas ionyRojas commented Jul 18, 2024 •
edited
Loading

📝 Description

🔗 Jira Ticket M2-7180

  • add helpers to validate the activity scheduled is on time and able to take the activity

Changes include:

  • validate the different types of schedule and validate if the current time is between the intervals of the scheduled time by the activity

📸 Screenshots

image
image

🪤 Peer Testing

✏️ Notes

@ionyRojas ionyRojas added the In Progress Some work in progress label Jul 18, 2024
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1868.d19gtpld8yi51u.amplifyapp.com

@ionyRojas ionyRojas removed the In Progress Some work in progress label Jul 18, 2024
@ionyRojas ionyRojas requested review from mbanting and farmerpaul July 18, 2024 21:10
@farmerpaul farmerpaul requested review from sultanofcardio and removed request for farmerpaul July 19, 2024 10:27
farmerpaul
farmerpaul reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@farmerpaul farmerpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I won't have time today to review this one before I'm off next week, but just wanted to note that we should always follow the PR naming convention. I'd suggest fix: Constrain Take Now to availability schedule (M2-7180) 🙏🏻

@ionyRojas ionyRojas changed the title Feature/m2 7180 add constraint feature: Constrain Take Now to availability schedule (M2-7180) Jul 19, 2024
@ionyRojas
Copy link
Contributor Author

@mbanting and should I also close this one ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmerpaul farmerpaul farmerpaul left review comments

@mbanting mbanting Awaiting requested review from mbanting

@sultanofcardio sultanofcardio Awaiting requested review from sultanofcardio

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ionyRojas @farmerpaul