Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Use dev-dependencies #11

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Use dev-dependencies #11

merged 4 commits into from
Sep 22, 2023

Conversation

Froxcey
Copy link
Contributor

@Froxcey Froxcey commented Sep 16, 2023

  • Move some dependencies to dev-dependencies
  • Remove subpackage
vibe

@Froxcey Froxcey added the type:dx&ql Check, build, scripts... label Sep 16, 2023
@Froxcey Froxcey self-assigned this Sep 16, 2023
@Froxcey Froxcey changed the title Small improvements Use dev-dependencies Sep 16, 2023
@Froxcey
Copy link
Contributor Author

Froxcey commented Sep 22, 2023

Why: Multichat only use those dependencies for types and tests under the hood. The actual clients are provided by downstream in production and uses dependency injection. It would be stupid to install millions of packages when the downstream only want to attach, for example, the djs client to Multichat. Maintainers can install dev-dependencies to get the nice type annotations and use it for tests, and downstream users can select which client to install and shrink the dependency tree.

@Froxcey Froxcey merged commit e8dfe24 into master Sep 22, 2023
1 check passed
@Froxcey Froxcey deleted the small-improvements branch September 22, 2023 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:dx&ql Check, build, scripts...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant