Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented lfs for all image png, jpeg, and jpg files resolving #62 #80

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
*.png filter=lfs diff=lfs merge=lfs -text
*.jpeg filter=lfs diff=lfs merge=lfs -text
*.jpg filter=lfs diff=lfs merge=lfs -text
Binary file modified PantryNodeReact/public/logo192.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified PantryNodeReact/public/logo512.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 17 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ In this project, we have implemented food pantry management using a NodeJS-based

> Back-End

- MongoDB
- Postgres
- Express JS
- JavaScript

Expand All @@ -50,6 +50,22 @@ In this project, we have implemented food pantry management using a NodeJS-based
$ cd PantryNode
```

### Git LFS

- If images or other large files are needed install [Git LFS](https://docs.github.com/en/repositories/working-with-files/managing-large-files/installing-git-large-file-storage)

- After installation run the follow commands to pull the images and not just text pointers

```shell
$ git lfs fetch --all
```

```shell
$ git lfs pull
```

### .env Setup

> Create a .env file with the following contents

#DB CONFIG
Expand Down
11 changes: 6 additions & 5 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ As an open source project, we welcome all contributors. Contributors shall abide

1. Create a feature branch with a concise 1-3 word name that adopts `snake_case` formatting and is descriptive enough to make its purpose clear without reviewing its source.
2. Commit discrete steps in resolving the issue with concise but descriptive commit messages. Any commit that completes resolving an issue should use [GitHub keywords for automating closing the issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) (e.g. "Adds main menu, **closes #1**). If anyone made meaningful contributions to the work (such as participating in pair programming), credit them with a mention in the commit message (e.g. "Correct segfault error; @username contributed") and they should be added as an "Assigned to" contributor if they are not already.
3. Push your changes to your feature branch and create a Pull Request. If your Pull Requests does not pass automated checks and/or contains unresolved conflicts, the person who submitted the PR is expected to address the problems before the PR will be reviewed.
4. All PR containing procedural code should also include associated and thorough [Jest unit tests](https://jestjs.io/) that document and test the expected behavior. All new tests (both existing regression tests and new tests) should run and pass on the feature branch. Branch coverage should be 100\%. If there is a compelling reason why that threshold cannot be reached, a detailed explanation should be provided along with the PR description.
5. A minimum of two other team members will review the Pull Request and provide discussion and/or constructive feedback. Engage in communication within the Issue comments.
6. If at least two other team members have reviewed and approved the Pull Request, it will be merged into the `main` branch using **Rebase and Merge**, unless the commits are too granular (according to the concensus of the reviewers) in which case **Squash and Merge** will summarize the commits into a single commit.
7. Once the Pull Request has been accepted and merged, the feature branch should be deleted from the repository
3. Ensure that all large files, including all images are tracked using Git LFS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the command needed for Git LFS here please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this is the place to add specifics commands as no other requires include commands to accomplish them. I added the commands needed to pull the repo into README and believe that should be sufficient.

4. Push your changes to your feature branch and create a Pull Request. If your Pull Requests does not pass automated checks and/or contains unresolved conflicts, the person who submitted the PR is expected to address the problems before the PR will be reviewed.
5. All PR containing procedural code should also include associated and thorough [Jest unit tests](https://jestjs.io/) that document and test the expected behavior. All new tests (both existing regression tests and new tests) should run and pass on the feature branch. Branch coverage should be 100\%. If there is a compelling reason why that threshold cannot be reached, a detailed explanation should be provided along with the PR description.
6. A minimum of two other team members will review the Pull Request and provide discussion and/or constructive feedback. Engage in communication within the Issue comments.
7. If at least two other team members have reviewed and approved the Pull Request, it will be merged into the `main` branch using **Rebase and Merge**, unless the commits are too granular (according to the concensus of the reviewers) in which case **Squash and Merge** will summarize the commits into a single commit.
8. Once the Pull Request has been accepted and merged, the feature branch should be deleted from the repository
Binary file modified docs/Foodbank ER Diagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/new.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/old.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/assets/cart.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/assets/donor.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/assets/exp.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/assets/report.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/assets/shop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/icons/book.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/icons/bread.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/icons/dairy.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/icons/fruit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/icons/meat.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/icons/pen.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/icons/pencil.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/icons/ready.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/icons/vege.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/log.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/logo_w.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/logo_w2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/magenta.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.