Dependency and workflow updates #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BrandtH22
commented
Jan 11, 2024
BrandtH22
commented
- replaces yarn with npm in deployment
- adds review deployment and deletion
- updates runnable import to referential path rather than absolute for ease of translation integrations
- adds trailing slash for seo
- adds Chia Docs to the header
- updates all dependencies, imports, and readme for running
- updates all dependencies, imports, and readme for running
- adds trailing slash for seo - adds Chia Docs to the header
- updates runnable import to referential path rather than absolute for ease of translation integrations
- replaces yarn with npm in deployment - adds review deployment and deletion
flips the npm install and npm ci commands
add k8s files
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @docusaurus/[email protected], [email protected], [email protected] |
fixes for the docker file and inclusion of cname
updates to domains used in review deploy workflow
BrandtH22
had a problem deploying
to
Review 256
GitHub Actions
Failure
adds the create cert namespace to negate exit 1
fixes the domain listed in the cert
Starttoaster
previously approved these changes
Jan 11, 2024
There was a problem hiding this comment.
My approval is for the CI/Docker/K8s manifest portions of the diff. I would gather additional reviewer(s) for the docs content where applicable. If future changes to docs content dismiss my review, that's fine. Just wanted to document my approval of that portion since github doesn't have a foolproof method of split approvals for PRs that do multiple things.
removes the yarn packages and package-lock json from the gitignore
Rigidity
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.