Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-1945 Accept a tx_filter param in get_block_header and exclude reward coins when the filter is not requested #18969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

We tend to use get_block_header in paths where we don't care about the transactions filter, by passing empty additions and removals, yet when a transaction block contains reward coins, we end up computing a non-empty one. Now we accept a tx_filter param that allows us to skip the filter computation entirely.

Current Behavior:

We generate a non-empty transactions filter when we get called with a transaction block that has reward coins, even if we pass empty additions and removals, which we usually do to signal not caring about the filter.

New Behavior:

We generate an empty transactions filter when we get called with tx_filter as False, even if we get a transaction block that has reward coins (and whether was pass additions and removals or not).

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Dec 3, 2024
@AmineKhaldi AmineKhaldi self-assigned this Dec 3, 2024
@AmineKhaldi AmineKhaldi marked this pull request as ready for review December 4, 2024 11:09
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner December 4, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant