Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1934] Remove get_new_* from DIDWallet #18968

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Dec 3, 2024

These methods are a temptation to ignore the reuse puzhash setting and should just be removed. This decreases duplication and complexity as well.

Also, apparently, these methods were unused.

@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Dec 3, 2024
@Quexington Quexington marked this pull request as ready for review December 3, 2024 15:39
@Quexington Quexington requested a review from a team as a code owner December 3, 2024 15:39
@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Dec 4, 2024
@pmaslana pmaslana merged commit 0cda424 into main Dec 4, 2024
363 checks passed
@pmaslana pmaslana deleted the quex.remove_get_new_puzzle_from_did_wallet branch December 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants