add test for a 1-block reorg in short_sync_backtrack() #18966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
Changed
almogdepaz
reviewed
Dec 3, 2024
almogdepaz
reviewed
Dec 3, 2024
almogdepaz
reviewed
Dec 3, 2024
arvidn
force-pushed
the
short-sync-backtrack-test
branch
from
e0a0f75
to
a275a82
Compare
arvidn
force-pushed
the
short-sync-backtrack-test
branch
from
a275a82
to
9f94652
Compare
almogdepaz
approved these changes
Dec 4, 2024
pmaslana
pushed a commit
that referenced
this pull request
Dec 4, 2024
* fix short_sync_backtrack * add test for a 1-block reorg in short_sync_backtrack() (#18966) --------- Co-authored-by: Arvid Norberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Add test coverage for the fixed bug. This test fails when run on top of main, but passes with Almog's fix.
Current Behavior:
1-block reorg in
short_sync_backtrack()is not covered by a test.New Behavior:
1-block reorg in
short_sync_backtrack()is covered by a test.