Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add root_path parameter to initialize_service_logging() #18961

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Dec 2, 2024

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky requested a review from a team as a code owner December 2, 2024 19:39
@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

File Coverage Missing Lines
chia/seeder/start_crawler.py 25.0% lines 70-71, 75-76, 86, 88
chia/simulator/start_simulator.py 60.0% lines 137, 139
chia/util/default_root.py 85.7% lines 27
Total Missing Coverage
85 lines 9 lines 89%

Copy link

Pull Request Test Coverage Report for Build 12126708734

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 76 of 85 (89.41%) changed or added relevant lines in 14 files are covered.
  • 25 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.05%) to 91.239%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/util/default_root.py 6 7 85.71%
chia/simulator/start_simulator.py 3 5 60.0%
chia/seeder/start_crawler.py 2 8 25.0%
Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 73.16%
chia/farmer/farmer.py 1 74.12%
chia/wallet/util/wallet_sync_utils.py 1 86.07%
chia/daemon/client.py 2 74.01%
chia/full_node/full_node_api.py 2 82.49%
chia/server/node_discovery.py 4 81.83%
chia/wallet/wallet_node.py 4 87.95%
chia/full_node/full_node.py 10 85.93%
Totals Coverage Status
Change from base Build 12125539501: 0.05%
Covered Lines: 103641
Relevant Lines: 113406

💛 - Coveralls

@altendky altendky requested a review from emlowe December 3, 2024 01:54
@pmaslana pmaslana merged commit e7d12c7 into main Dec 3, 2024
364 of 365 checks passed
@pmaslana pmaslana deleted the initialize_service_logging_root_path_parameter branch December 3, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants