Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new configuration option to log the first 6 hex digits of coins #18893

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 19, 2024

Purpose:

Make it easier (and possible) to track down inconsistencies with the coin table.

Current Behavior:

We don't log coins additions and removals, so if there's a coin error, it's difficult to know why there was an error.

New Behavior:

There's a new configuration option to enable logging of additions, removals and reorged coins (only the first 6 hex digits, to save space).

Testing Notes:

example output:

2024-11-19T14:21:52.952 0.0.0 full_node chia.consensus.blockchain: INFO     adding new block to coin_store, 47 spends
2024-11-19T14:21:52.953 0.0.0 full_node chia.consensus.blockchain: INFO     additions: aa4381,6ac924,f5e25c,955af8,04e5c7,b21752,987a59,ba0289,fe1cbe,f2436c,fee746,93b084,4607a9,57c420,3e3627,51e3db,ed60b5,bb0fc8,511477,b81b93,0d9961,797828,a10678,9c4c40,af54bb,ba7d68,8c66f2,3bf4bc,db9c10,59b0f0,b463f7,0cabbd,383210,237d4a,b90a79,c1edd4,6a6999,f63ba9,34f65d,e74f27,004ce5,b6bf5c,d0dbac,9e36a5,135923,e714a2,b9b40d,ec3e6e
2024-11-19T14:21:52.953 0.0.0 full_node chia.consensus.blockchain: INFO     removals: 0aef99,2e6aca,6d8a0d,83a5a2,8d3132,224b72,8f2546,75b407,44d4dc,d655d4,7d085e,cfd5e2,a7e876,b0d1a0,64b73c,8aef7e,2d7f30,77846f,5e6d35,9daed0,813f53,c883af,bc6348,ca15fe,7bd77a,2130d5,7a42cc,2b7d44,79a113,c613df,87af45,8808c9,3fa854,bcf05a,30bd2c,401768,41dc99,d9122b,1b341a,3bfa44,5f570f,33ca55,27785c,b60b08,de1796,eacafc,5d1de6

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 19, 2024
@aqk
Copy link
Contributor

aqk commented Nov 19, 2024

"add new configuration option to log the first 6 hex digits coins"
->
"add new configuration option to log the first 6 hex digits [of] coins"

@arvidn arvidn changed the title add new configuration option to log the first 6 hex digits coins add new configuration option to log the first 6 hex digits of coins Nov 19, 2024
@arvidn arvidn requested a review from aqk November 19, 2024 14:24
@arvidn arvidn marked this pull request as ready for review November 19, 2024 14:24
@arvidn arvidn requested a review from a team as a code owner November 19, 2024 14:24
Copy link

Pull Request Test Coverage Report for Build 11969863064

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 15 (53.33%) changed or added relevant lines in 4 files are covered.
  • 46 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.03%) to 91.158%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/consensus/block_body_validation.py 2 4 50.0%
chia/consensus/blockchain.py 4 9 44.44%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/daemon/server.py 1 83.22%
chia/plotters/plotters.py 1 90.94%
chia/rpc/rpc_server.py 1 89.13%
chia/full_node/full_node.py 3 85.97%
chia/full_node/weight_proof.py 4 90.48%
chia/plotters/madmax.py 6 44.58%
chia/wallet/wallet_node.py 7 87.89%
chia/_tests/core/util/test_lockfile.py 22 77.31%
Totals Coverage Status
Change from base Build 11962414890: -0.03%
Covered Lines: 103386
Relevant Lines: 113217

💛 - Coveralls

@arvidn arvidn force-pushed the log_coins branch 4 times, most recently from b2d7a66 to 30a880d Compare November 27, 2024 17:45
…ns added, removed and reorged (off by default)
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@pmaslana pmaslana merged commit 98f7f88 into main Dec 3, 2024
362 checks passed
@pmaslana pmaslana deleted the log_coins branch December 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants