Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-783: Stop auto-subscribing to local stores #18166

Merged
merged 22 commits into from
Aug 7, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jun 12, 2024

Stop auto-subscribing to local stores found in the DB that aren't already subscribed. Don't fully subscribe to my own stores - although make sure to process them correctly to create DAT files.

Can be turned back to the original behaviour by putting auto_subscribe_to_local_stores to True in config.yaml

Add some tests

@emlowe emlowe added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jun 12, 2024
@emlowe emlowe changed the title Stop auto-subscribing to local stores CHIA-783: Stop auto-subscribing to local stores Jun 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main coverage-diff labels Jul 10, 2024
Copy link

Pull Request Test Coverage Report for Build 9864738094

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 36 of 46 (78.26%) changed or added relevant lines in 2 files are covered.
  • 1809 unchanged lines in 77 files lost coverage.
  • Overall coverage increased (+0.09%) to 90.952%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/data_layer/data_layer.py 8 18 44.44%
Files with Coverage Reduction New Missed Lines %
chia/types/eligible_coin_spends.py 1 98.06%
chia/util/keyring_wrapper.py 1 73.83%
chia/_tests/wallet/rpc/test_wallet_rpc.py 1 99.67%
chia/full_node/mempool.py 1 99.71%
chia/rpc/rpc_server.py 1 88.7%
chia/_tests/wallet/dao_wallet/test_dao_wallets.py 1 99.95%
chia/cmds/chia.py 1 76.47%
chia/_tests/core/full_node/test_transactions.py 1 99.11%
chia/full_node/generator.py 1 91.67%
chia/_tests/wallet/test_notifications.py 1 99.33%
Totals Coverage Status
Change from base Build 9486908730: 0.09%
Covered Lines: 101431
Relevant Lines: 111474

💛 - Coveralls

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 18, 2024
@emlowe emlowe marked this pull request as ready for review July 23, 2024 17:34
@emlowe emlowe requested a review from a team as a code owner July 23, 2024 17:34
@emlowe emlowe requested review from altendky and fchirica July 23, 2024 17:34
@emlowe emlowe changed the base branch from main to release/2.4.3 July 24, 2024 19:46
@emlowe
Copy link
Contributor Author

emlowe commented Jul 24, 2024

close and reopen for new CI run

@emlowe emlowe closed this Jul 24, 2024
@emlowe emlowe reopened this Jul 24, 2024
chia/_tests/core/data_layer/test_data_rpc.py Outdated Show resolved Hide resolved
chia/data_layer/data_layer.py Outdated Show resolved Hide resolved
@emlowe
Copy link
Contributor Author

emlowe commented Jul 31, 2024

close and reopen for CI

@emlowe emlowe closed this Jul 31, 2024
@emlowe emlowe reopened this Jul 31, 2024
@Starttoaster Starttoaster merged commit d1464da into release/2.4.3 Aug 7, 2024
1993 of 2000 checks passed
@Starttoaster Starttoaster deleted the EL.dl-auto-subs-change branch August 7, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants