Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Electron to v30 #2326

Merged
merged 1 commit into from
May 3, 2024
Merged

Upgrade Electron to v30 #2326

merged 1 commit into from
May 3, 2024

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Apr 23, 2024

Summary

  • Increase the minimum NodeJS version to 18.18.2 (This is also the requirement for [email protected]) since NodeJS 16.x is outdated.
  • Upgraded @electron/remote to 2.1.2 (previously 2.0.10)
  • Upgraded electron to 30.0.1 (previously 27.0.0)
  • Upgraded electron-winstaller to 5.3.1 (previously 5.1.0)
  • Modified electron/main.ts

Test

OS Arch Version Launch
macOS arm64 14.3.1 OK
Windows x86_64 10 OK
Ubuntu x86_64 22.04 OK
Fedora x86_64 39 OK

Why modified electron/main.ts?

I found that there is a flicker on GUI launch when darkmode is enabled after upgrading Electron to 30.0.1.

blink-with-electron-30.mp4

@ChiaMineJP ChiaMineJP self-assigned this Apr 23, 2024
@ChiaMineJP ChiaMineJP changed the title Cmj.electron 30 Upgrade Electron to v30 Apr 23, 2024
Copy link

socket-security bot commented Apr 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@electron/[email protected] None 0 72 kB electron-cfa
npm/[email protected] filesystem, shell Transitive: environment +27 36.2 MB electron-cfa
npm/[email protected] environment, filesystem, shell Transitive: eval, network +69 5.06 MB electron-nightly

🚮 Removed packages: npm/@electron/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@ChiaMineJP ChiaMineJP requested review from seeden and emlowe April 24, 2024 15:08
@ChiaMineJP ChiaMineJP marked this pull request as ready for review April 24, 2024 15:09
@ChiaMineJP ChiaMineJP merged commit 47bff33 into main May 3, 2024
9 checks passed
@ChiaMineJP ChiaMineJP deleted the cmj.electron-30 branch May 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants