Walletconnect multiple key select - enable "Key Switch" setting #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting multiple keys inside wallet-connect dialog, show warning and after confirmation, enable "Key Switching" setting
|
We should engage with @sethjenks to polish the UX here. I have some reservations about the current interactions that this PR introduces. |
…n-multi-select # Conflicts: # packages/gui/src/components/walletConnect/WalletConnectAddConnectionDialog.tsx
paninaro
reviewed
Aug 24, 2023
packages/gui/src/components/walletConnect/WalletConnectAddConnectionDialog.tsx
Outdated
Show resolved
Hide resolved
paninaro
reviewed
Aug 24, 2023
packages/gui/src/components/walletConnect/WalletConnectAddConnectionDialog.tsx
Outdated
Show resolved
Hide resolved
paninaro
reviewed
Aug 24, 2023
packages/gui/src/components/walletConnect/WalletConnectAddConnectionDialog.tsx
Show resolved
Hide resolved
paninaro
approved these changes
Aug 24, 2023
paninaro
deleted the
rifeljm/walletconnect-enable-key-switching-on-multi-select
branch
paninaro
added a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Sep 14, 2023
* Fixed typo by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1915 * add workflow to sync crowdin and sign commits by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1918 * use public k8s runners by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1920 * Use public runners by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1921 * fix incorrect paths by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1922 * Crowdin configuration by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1923 * added support for execute into wc by @seeden in Chia-Network/chia-blockchain-gui#1912 * Crowdin configuration by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1924 * update colors in gui by @lipalong in Chia-Network/chia-blockchain-gui#1927 * Color fixes in gui by @lipalong in Chia-Network/chia-blockchain-gui#1931 * Update TS in all useWatch() instances by @zsolt-dev in Chia-Network/chia-blockchain-gui#1938 * Update @babel packages to 7.22.x or latest available by @paninaro in Chia-Network/chia-blockchain-gui#1966 * fixed auto login by @seeden in Chia-Network/chia-blockchain-gui#1982 * Crowdin configuration by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1984 * Crowdin configuration by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1985 * remove crowdin config created by automation by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1993 * add emojis to address book; address book design updates; cleanup by @lipalong in Chia-Network/chia-blockchain-gui#1999 * Seeden/scrollbars2 by @seeden in Chia-Network/chia-blockchain-gui#2000 * WalletConnect signMessageById/Address commands to support signing hex encoded messages by @rifeljm in Chia-Network/chia-blockchain-gui#2002 * increased number of max event listeners for api services by @seeden in Chia-Network/chia-blockchain-gui#2008 * used correct box-shadow for dark mode by @seeden in Chia-Network/chia-blockchain-gui#2010 * CrCat functionality by @zsolt-dev in Chia-Network/chia-blockchain-gui#2009 * Remove autoSelect behavior so that a row isn't selected on blur by @paninaro in Chia-Network/chia-blockchain-gui#2014 * Update Readme file (debugging and simulator sections) by @zsolt-dev in Chia-Network/chia-blockchain-gui#2016 * snyk updates by @seeden in Chia-Network/chia-blockchain-gui#2017 * Support plot filter change for testnet10 by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2015 * Refactoring playwright scripts to point to designated wallet by @jfawChia in Chia-Network/chia-blockchain-gui#1899 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2022 * Fix crash when populating keys that lack an emoji/theme entry by @paninaro in Chia-Network/chia-blockchain-gui#2024 * Walletconnect multiple key select - enable "Key Switch" setting by @rifeljm in Chia-Network/chia-blockchain-gui#2003 * Update package-lock.json by @paninaro in Chia-Network/chia-blockchain-gui#2028 * Fix address entry when entered directly instead of using the selection by @paninaro in Chia-Network/chia-blockchain-gui#2037 * updated locale files by @seeden in Chia-Network/chia-blockchain-gui#2043 * removed incompatible react suspender by @seeden in Chia-Network/chia-blockchain-gui#2050 * Remove fingerprint prefs when removing a wallet by @rifeljm in Chia-Network/chia-blockchain-gui#2045 * Update Electron to 26.1.0 for security fixes by @paninaro in Chia-Network/chia-blockchain-gui#2052 * CR-CAT offers functionality by @zsolt-dev in Chia-Network/chia-blockchain-gui#2047 * Update Node to 18.16.1 from 16.20.1 by @paninaro in Chia-Network/chia-blockchain-gui#2054 * getPublicKey by @rifeljm in Chia-Network/chia-blockchain-gui#2051 * Quick fix for the crash when clicking on the Plots tab by @paninaro in Chia-Network/chia-blockchain-gui#2057 * Bladebit hybrid diskmode by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2056 * Fixed effective plot size values by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2062 * Removed `-no-direct_downloads` option from bladebit by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2061 * Rifeljm/#576 removing walletconnect create new cat wallet by @rifeljm in Chia-Network/chia-blockchain-gui#2064 * Npp remove j2 by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2069 * Move away from lerna to npm with workspaces by @paninaro in Chia-Network/chia-blockchain-gui#2066 * Update sync-crowdin.yml by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2071 * Nirajpathak13 crowdin sync debug by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2072 * Update crowdin.yml by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2073 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2074 * Add a tooltip for USDSC (Stably USDS Classic) in the token listing by @paninaro in Chia-Network/chia-blockchain-gui#2067 * Show both Launcher Id and Coin Id by @rifeljm in Chia-Network/chia-blockchain-gui#2075 * Update localized strings by @paninaro in Chia-Network/chia-blockchain-gui#2078 * Update sync-crowdin.yml by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2079 * Update sync-crowdin.yml by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2080 * preserve_hierarchy: true so the multiple packages will work https://d… by @cmmarslender in Chia-Network/chia-blockchain-gui#2081 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2077 * expiring offers for gui by @lipalong in Chia-Network/chia-blockchain-gui#2076 * Bump Electron to 26.2.1 for a security fix by @paninaro in Chia-Network/chia-blockchain-gui#2082 * Set the branch to pull from by @cmmarslender in Chia-Network/chia-blockchain-gui#2084 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2083 * @github-actions made their first contribution in Chia-Network/chia-blockchain-gui#2022 **Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0...2.1.0-rc1
paninaro
added a commit
to Chia-Network/chia-blockchain
that referenced
this pull request
Sep 14, 2023
* Fixed typo by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1915 * add workflow to sync crowdin and sign commits by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1918 * use public k8s runners by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1920 * Use public runners by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1921 * fix incorrect paths by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1922 * Crowdin configuration by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1923 * added support for execute into wc by @seeden in Chia-Network/chia-blockchain-gui#1912 * Crowdin configuration by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1924 * update colors in gui by @lipalong in Chia-Network/chia-blockchain-gui#1927 * Color fixes in gui by @lipalong in Chia-Network/chia-blockchain-gui#1931 * Update TS in all useWatch() instances by @zsolt-dev in Chia-Network/chia-blockchain-gui#1938 * Update @babel packages to 7.22.x or latest available by @paninaro in Chia-Network/chia-blockchain-gui#1966 * fixed auto login by @seeden in Chia-Network/chia-blockchain-gui#1982 * Crowdin configuration by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1984 * Crowdin configuration by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1985 * remove crowdin config created by automation by @nirajpathak13 in Chia-Network/chia-blockchain-gui#1993 * add emojis to address book; address book design updates; cleanup by @lipalong in Chia-Network/chia-blockchain-gui#1999 * Seeden/scrollbars2 by @seeden in Chia-Network/chia-blockchain-gui#2000 * WalletConnect signMessageById/Address commands to support signing hex encoded messages by @rifeljm in Chia-Network/chia-blockchain-gui#2002 * increased number of max event listeners for api services by @seeden in Chia-Network/chia-blockchain-gui#2008 * used correct box-shadow for dark mode by @seeden in Chia-Network/chia-blockchain-gui#2010 * CrCat functionality by @zsolt-dev in Chia-Network/chia-blockchain-gui#2009 * Remove autoSelect behavior so that a row isn't selected on blur by @paninaro in Chia-Network/chia-blockchain-gui#2014 * Update Readme file (debugging and simulator sections) by @zsolt-dev in Chia-Network/chia-blockchain-gui#2016 * snyk updates by @seeden in Chia-Network/chia-blockchain-gui#2017 * Support plot filter change for testnet10 by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2015 * Refactoring playwright scripts to point to designated wallet by @jfawChia in Chia-Network/chia-blockchain-gui#1899 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2022 * Fix crash when populating keys that lack an emoji/theme entry by @paninaro in Chia-Network/chia-blockchain-gui#2024 * Walletconnect multiple key select - enable "Key Switch" setting by @rifeljm in Chia-Network/chia-blockchain-gui#2003 * Update package-lock.json by @paninaro in Chia-Network/chia-blockchain-gui#2028 * Fix address entry when entered directly instead of using the selection by @paninaro in Chia-Network/chia-blockchain-gui#2037 * updated locale files by @seeden in Chia-Network/chia-blockchain-gui#2043 * removed incompatible react suspender by @seeden in Chia-Network/chia-blockchain-gui#2050 * Remove fingerprint prefs when removing a wallet by @rifeljm in Chia-Network/chia-blockchain-gui#2045 * Update Electron to 26.1.0 for security fixes by @paninaro in Chia-Network/chia-blockchain-gui#2052 * CR-CAT offers functionality by @zsolt-dev in Chia-Network/chia-blockchain-gui#2047 * Update Node to 18.16.1 from 16.20.1 by @paninaro in Chia-Network/chia-blockchain-gui#2054 * getPublicKey by @rifeljm in Chia-Network/chia-blockchain-gui#2051 * Quick fix for the crash when clicking on the Plots tab by @paninaro in Chia-Network/chia-blockchain-gui#2057 * Bladebit hybrid diskmode by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2056 * Fixed effective plot size values by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2062 * Removed `-no-direct_downloads` option from bladebit by @ChiaMineJP in Chia-Network/chia-blockchain-gui#2061 * Rifeljm/#576 removing walletconnect create new cat wallet by @rifeljm in Chia-Network/chia-blockchain-gui#2064 * Npp remove j2 by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2069 * Move away from lerna to npm with workspaces by @paninaro in Chia-Network/chia-blockchain-gui#2066 * Update sync-crowdin.yml by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2071 * Nirajpathak13 crowdin sync debug by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2072 * Update crowdin.yml by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2073 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2074 * Add a tooltip for USDSC (Stably USDS Classic) in the token listing by @paninaro in Chia-Network/chia-blockchain-gui#2067 * Show both Launcher Id and Coin Id by @rifeljm in Chia-Network/chia-blockchain-gui#2075 * Update localized strings by @paninaro in Chia-Network/chia-blockchain-gui#2078 * Update sync-crowdin.yml by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2079 * Update sync-crowdin.yml by @nirajpathak13 in Chia-Network/chia-blockchain-gui#2080 * preserve_hierarchy: true so the multiple packages will work https://d… by @cmmarslender in Chia-Network/chia-blockchain-gui#2081 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2077 * expiring offers for gui by @lipalong in Chia-Network/chia-blockchain-gui#2076 * Bump Electron to 26.2.1 for a security fix by @paninaro in Chia-Network/chia-blockchain-gui#2082 * Set the branch to pull from by @cmmarslender in Chia-Network/chia-blockchain-gui#2084 * New Crowdin Translations by @github-actions in Chia-Network/chia-blockchain-gui#2083 * @github-actions made their first contribution in Chia-Network/chia-blockchain-gui#2022 **Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0...2.1.0-rc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting multiple keys inside wallet-connect dialog, show warning and after confirmation, enable "Key Switching" setting