Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compressed plot size texts #1987

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Aug 8, 2023

Source: https://docs.chia.net/k-sizes/

image

Also this PR hides compress option for bladebit_disk.

@ChiaMineJP ChiaMineJP self-assigned this Aug 8, 2023
) {
return {
value: kSize,
label: `k=${kSize} (Effective plot size: ${item.effectivePlotSize}, Temporary space: ${item.workspace})`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this label being localized somewhere else? Same question for the label on line 74

Copy link
Contributor

@paninaro paninaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this as-is. We can address the localization question separately.

@paninaro paninaro merged commit 8f43234 into release/2.0.0 Aug 9, 2023
12 checks passed
@paninaro paninaro deleted the cmj.fix-plot-size-texts branch August 9, 2023 15:52
paninaro added a commit to Chia-Network/chia-blockchain that referenced this pull request Aug 9, 2023
* Use lerna 7.1.3 and nx 16.3.2 for macos 10.14 building by @emlowe in Chia-Network/chia-blockchain-gui#1917
* Fix "From" to "To" in wallet history by @zsolt-dev in Chia-Network/chia-blockchain-gui#1939
* Hide harvester tab in setting page in wallet mode by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1941
* Update "Clawback will be applied." warning by @zsolt-dev in Chia-Network/chia-blockchain-gui#1940
* Fixed add plot page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1954
* Add clawBackExpiration behind the expand TX row for clawback sender by @zsolt-dev in Chia-Network/chia-blockchain-gui#1950
* Hide clawback TXs while wallet is syncing by @zsolt-dev in Chia-Network/chia-blockchain-gui#1951
* Updated harvester setting page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1949
* Design fixes to Address Book by @lipalong in Chia-Network/chia-blockchain-gui#1957
* Hide GPU setting when it is not available by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1959
* `start_plotting` fix by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1958
* Icon updates by @paninaro in Chia-Network/chia-blockchain-gui#1967
* The label of `last block won` is now `Never` when there are no blocks… by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1971
* Hide temp folder selection on cudaplot by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1972
* Update Electron to 25.4.0 for security fixes by @paninaro in Chia-Network/chia-blockchain-gui#1976
* Plot filter value now is the function of height by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1979
* Fixed inconsistent step count by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1986
* Added compressed plot size texts by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1987

**Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0-rc2...2.0.0-rc4
wallentx pushed a commit to Chia-Network/chia-blockchain that referenced this pull request Aug 9, 2023
Bump chia-blockchaing-gui to 8f43234de14eeb04df4fca19cb1de1184ec47f53

* Use lerna 7.1.3 and nx 16.3.2 for macos 10.14 building by @emlowe in Chia-Network/chia-blockchain-gui#1917
* Fix "From" to "To" in wallet history by @zsolt-dev in Chia-Network/chia-blockchain-gui#1939
* Hide harvester tab in setting page in wallet mode by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1941
* Update "Clawback will be applied." warning by @zsolt-dev in Chia-Network/chia-blockchain-gui#1940
* Fixed add plot page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1954
* Add clawBackExpiration behind the expand TX row for clawback sender by @zsolt-dev in Chia-Network/chia-blockchain-gui#1950
* Hide clawback TXs while wallet is syncing by @zsolt-dev in Chia-Network/chia-blockchain-gui#1951
* Updated harvester setting page by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1949
* Design fixes to Address Book by @lipalong in Chia-Network/chia-blockchain-gui#1957
* Hide GPU setting when it is not available by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1959
* `start_plotting` fix by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1958
* Icon updates by @paninaro in Chia-Network/chia-blockchain-gui#1967
* The label of `last block won` is now `Never` when there are no blocks… by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1971
* Hide temp folder selection on cudaplot by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1972
* Update Electron to 25.4.0 for security fixes by @paninaro in Chia-Network/chia-blockchain-gui#1976
* Plot filter value now is the function of height by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1979
* Fixed inconsistent step count by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1986
* Added compressed plot size texts by @ChiaMineJP in Chia-Network/chia-blockchain-gui#1987

**Full Changelog**: Chia-Network/chia-blockchain-gui@2.0.0-rc2...2.0.0-rc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants