Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filesystem): deadlock when calling AddExcluded #7216

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yanhua1133
Copy link

Closes #7215

Reason for Proposed Changes

  • the call of AddExcluded triggers a deadlock, the call seems unnecessary.

Proposed Changes
Just remove the call of AddExcluded, so that the lock in AddExcluded will not be added.
In line 247 filepath.SkipDir is returned anyway to skip the dir (i.e., .terraform), so the functionality is preserved.

-- 243 			err := s.AddExcluded([]string{info.Name()})
-- 244 			if err != nil {
-- 245 				return true, err
-- 246 			}

I submit this contribution under the Apache-2.0 license.

@yanhua1133 yanhua1133 requested a review from a team as a code owner July 24, 2024 12:26
@github-actions github-actions bot added community Community contribution bug Something isn't working terraform Terraform query labels Jul 24, 2024
@cx-ruiaraujo cx-ruiaraujo changed the title Fix bug #7215 fix(queries): bug #7215 Jul 24, 2024
@github-actions github-actions bot added the query New query feature label Jul 24, 2024
@cx-ruiaraujo cx-ruiaraujo changed the title fix(queries): bug #7215 fix(filesystem): deadlock when calling AddExcluded Jul 24, 2024
@github-actions github-actions bot removed bug Something isn't working query New query feature labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(terraform): a deadlock in filesystem.go since v1.7.13
2 participants