Read qr code playbook fix (demisto#36500)

* Added a condition for ReadQRCode * Added release notes * Updated image * Fixed description * Another filtering
CheckPointSW · Sep 25, 2024 · b28f77a · b28f77a
1 parent 26983da
commit b28f77a
Show file tree

Hide file tree

Showing 4 changed files with 95 additions and 13 deletions.
diff --git a/Packs/CommonPlaybooks/Playbooks/playbook-Extract_Indicators_From_File_-_Generic_v2_4_5.yml b/Packs/CommonPlaybooks/Playbooks/playbook-Extract_Indicators_From_File_-_Generic_v2_4_5.yml
@@ -1106,10 +1106,10 @@ tasks:
     isautoswitchedtoquietmode: false
   "14":
     id: "14"
-    taskid: a81da43e-d75f-4860-8c79-d59851d1410c
+    taskid: b00731f6-af3b-4011-8be2-3680f778777e
     type: regular
     task:
-      id: a81da43e-d75f-4860-8c79-d59851d1410c
+      id: b00731f6-af3b-4011-8be2-3680f778777e
       version: -1
       name: Extract text from images
       description: Extracts text from PNG, JPEG, and GIF image files, and uses auto-extract to get reputation for indicators.
@@ -1170,8 +1170,8 @@ tasks:
     view: |-
       {
         "position": {
-          "x": 2190,
-          "y": 1310
+          "x": 2640,
+          "y": 1320
         }
       }
     note: false
@@ -1601,7 +1601,7 @@ tasks:
       - "10"
       "yes":
       - "13"
-      - "24"
+      - "28"
     separatecontext: false
     conditions:
     - label: "yes"
@@ -1813,10 +1813,10 @@ tasks:
     isautoswitchedtoquietmode: false
   "24":
     id: "24"
-    taskid: 424f69f0-0339-42f1-8a9e-c73f4e171412
+    taskid: ca969180-8bc8-43a8-8018-6fc398457815
     type: regular
     task:
-      id: 424f69f0-0339-42f1-8a9e-c73f4e171412
+      id: ca969180-8bc8-43a8-8018-6fc398457815
       version: -1
       name: Extract Text from QR Code
       description: Extracts the text from a QR code. The output of this script includes the output of the script "extractIndicators" run on the text extracted from the QR code.
@@ -1835,12 +1835,28 @@ tasks:
           - - operator: containsGeneral
               left:
                 value:
-                  simple: inputs.File.Type
+                  simple: inputs.File.Info
                 iscontext: true
               right:
                 value:
-                  simple: image
+                  simple: image/png
               ignorecase: true
+            - operator: isEqualString
+              left:
+                value:
+                  simple: inputs.File.Info
+                iscontext: true
+              right:
+                value:
+                  simple: image/jpeg
+            - operator: isEqualString
+              left:
+                value:
+                  simple: inputs.File.Info
+                iscontext: true
+              right:
+                value:
+                  simple: image/jpg
           accessor: EntryID
           transformers:
           - operator: append
@@ -1862,8 +1878,8 @@ tasks:
     view: |-
       {
         "position": {
-          "x": 1530,
-          "y": 1310
+          "x": 1320,
+          "y": 1330
         }
       }
     note: false
@@ -2122,6 +2138,66 @@ tasks:
     quietmode: 0
     isoversize: false
     isautoswitchedtoquietmode: false
+  "28":
+    id: "28"
+    taskid: ff1834e4-8544-4395-86e4-81f108cf6920
+    type: condition
+    task:
+      id: ff1834e4-8544-4395-86e4-81f108cf6920
+      version: -1
+      name: Does ReadQRCode support the image?
+      type: condition
+      iscommand: false
+      brand: ""
+      description: ""
+    nexttasks:
+      '#default#':
+      - "19"
+      "yes":
+      - "24"
+    separatecontext: false
+    conditions:
+    - label: "yes"
+      condition:
+      - - operator: isEqualString
+          left:
+            value:
+              simple: inputs.File.Info
+            iscontext: true
+          right:
+            value:
+              simple: image/png
+        - operator: isEqualString
+          left:
+            value:
+              simple: inputs.File.Info
+            iscontext: true
+          right:
+            value:
+              simple: image/jpeg
+        - operator: isEqualString
+          left:
+            value:
+              simple: inputs.File.Info
+            iscontext: true
+          right:
+            value:
+              simple: image/jpg
+    continueonerrortype: ""
+    view: |-
+      {
+        "position": {
+          "x": 1820,
+          "y": 1050
+        }
+      }
+    note: false
+    timertriggers: []
+    ignoreworker: false
+    skipunavailable: false
+    quietmode: 0
+    isoversize: false
+    isautoswitchedtoquietmode: false
 view: |-
   {
     "linkLabelsPosition": {
@@ -2142,7 +2218,7 @@ view: |-
     "paper": {
       "dimensions": {
         "height": 1815,
-        "width": 3545,
+        "width": 3995,
         "x": -975,
         "y": -10
       }

diff --git a/Packs/CommonPlaybooks/ReleaseNotes/2_6_42.md b/Packs/CommonPlaybooks/ReleaseNotes/2_6_42.md
@@ -0,0 +1,6 @@
+
+#### Playbooks
+
+##### Extract Indicators From File - Generic v2
+
+- Fixed an issue where the **ReadQRCode** task failed when a *gif* file was given.
diff --git a/Packs/CommonPlaybooks/doc_files/Extract_Indicators_From_File_-_Generic_v2.png b/Packs/CommonPlaybooks/doc_files/Extract_Indicators_From_File_-_Generic_v2.png
diff --git a/Packs/CommonPlaybooks/pack_metadata.json b/Packs/CommonPlaybooks/pack_metadata.json
@@ -2,7 +2,7 @@
     "name": "Common Playbooks",
     "description": "Frequently used playbooks pack.",
     "support": "xsoar",
-    "currentVersion": "2.6.41",
+    "currentVersion": "2.6.42",
     "author": "Cortex XSOAR",
     "url": "https://www.paloaltonetworks.com/cortex",
     "email": "",