Defer importing twisted.internet.reactor, fixes "reactor already installed"
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
importing that module initializes the reactor,
which makes it impossible to change the reactor in the command-line
(-r option). Using the command-line option failed with the message:
The specified reactor cannot be used, failed with error: reactor already installed.
Found in scrapy's asyncio documentation:
https://docs.scrapy.org/en/latest/topics/asyncio.html#handling-a-pre-installed-reactor
|
|
Nice! This PR works for me and avoids the old hacks we had to avoid the "reactor already installed" issue. Tested with twisted 16.4.0 and 22.4.0 and confirmed CF is populated as normal |
shroffk
approved these changes
Aug 8, 2024
tynanford
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running RecCeiver with 24.3.0, I found the same issue as #37:
but initializing a
dropin.cachedid not work out for me. After some research, I found scrapy's asyncio documentation:https://docs.scrapy.org/en/latest/topics/asyncio.html#handling-a-pre-installed-reactor
Turns out importing
twisted.internet.reactorinitializes a default reactor, which makes it impossible to change the reactor in the command-line (-roption).So this PR defers importing reactor, which makes RecCeiver work for me.
This PR was only crudely tested, by seeing that the application doesn't crash.