Update docker-compose for local dev #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msherman64
approved these changes
Oct 7, 2024
Comment on lines
109
to
111
| EDGE_OS_APPLICATION_CREDENTIAL_ID=<grab this from chi@edge keystone> | ||
| EDGE_OS_APPLICATION_CREDENTIAL_SECRET=<grab this from chi@edge keystone> No newline at end of file | ||
| EDGE_OS_APPLICATION_CREDENTIAL_SECRET=<grab this from chi@edge keystone> |
There was a problem hiding this comment.
AFAIK this is for the chi@edge resource calendar, I'm assuming we don't test this in local dev yet.
There was a problem hiding this comment.
what required the change from 127.0.0.1 to leaving the IP out?
AFAIK docker defaults to "listen on all addresses", did this need to be accessible externally to the local dev machine? Are there any security issues?
There was a problem hiding this comment.
Correct. Since this config was intended for use on a KVM with access via sshuttle, it no longer can bind to just 127.0.0.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.