Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update package.json for ARM Mac #1752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Update package.json for ARM Mac #1752

wants to merge 1 commit into from
+2 −0

Conversation

ishaansehgal99
Copy link
Contributor

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 20, 2025
@ishaansehgal99 ishaansehgal99 mentioned this pull request Jan 20, 2025
Open
dokterbob
dokterbob requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@dokterbob dokterbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

However, updating indirect dependencies with pnpm is simply a matter of updating either the direct dependencies, which then update indirect dependencies or just updating the lockfile: https://pnpm.io/cli/update

Do please try again (e.g. git reset --hard main) -- as I don't have an ARM platform available for testing.

package.json
@@ -1,5 +1,6 @@
{
"devDependencies": {
"@rollup/rollup-darwin-arm64": "^4.30.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to have platform-dependent stuff here.

package.json
@@ -12,6 +13,7 @@
"kill-port": "^2.0.1",
"lint-staged": "^13.3.0",
"prettier": "^2.8.8",
"rollup": "3.29.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an indirect dependency and AFAIK we don't need to have it explicitly mentioned here.

@dokterbob dokterbob added the blocked Awaiting update or feedback from user after initial review/comments. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokterbob dokterbob dokterbob requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
blocked Awaiting update or feedback from user after initial review/comments. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishaansehgal99 @dokterbob