-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie-based auth #1521
base: main
Are you sure you want to change the base?
Cookie-based auth #1521
Conversation
c49b0d8
to
38f7ea9
Compare
There's currently E2E test failures in:
This is kind of to be expected, given the scale of this refactor. In addition, we need to make sure that files are served from a place which does not have API access, e.g. the files should really be untrusted. Otherwise, an LLM or whoever uploads files could call the Chainlit API on the user's behalf by crafting malicious HTML with JS. To get there, we need to:
This would be a good moment to 'go all in' in terms of file security. We could also postpone this to a later PR and/or explicitly document that files in their current implementation should not come from untrusted sources (e.g. AI-generated or from 3rd parties). |
abfc636
to
497714c
Compare
* Organise imports and formatting. * Log uncaught exceptions in data layer. * Typing cleanup and explicit assertions.
And why are we silently doing this _only_ when on401() is defined?
Prevents redundant redirect.
83a4474
to
441d198
Compare
This reverts commit f951c0b.
Just 2 more tests missing:
|
Implementation of #1520