HOT FIX - Fixes Elements by reverting bug in #1441 #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
dosubot
bot
added
backend
dokterbob
approved these changes
Oct 25, 2024
dokterbob
pushed a commit
that referenced
this pull request
Oct 25, 2024
dokterbob
added a commit
that referenced
this pull request
Oct 25, 2024
* Update server.py (#1474) Solving the underlying issue properly requires moving to HTTP only cookies, which is out of scope for now (we want to properly clean up auth). We're gonna ship this ASAP. This reopens #1101 and #1438 . * Changelog for 1.3.1 and 2.0.dev2. * Bump version to 1.3.1. --------- Co-authored-by: Josh Hayes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
project/file/{file_id}endpoint always returns 401 HTTP error. This prevent any Element from being displayed. Fixes #1472Important
Users should not upgrade to versions 1.3.0 or 2.0.dev1
This comments out the problematic code and adds TODOs. This reopens #1101 and #1438 .