Fix: DynamoDB Typeerror with AWS Bedrock #1163
Conversation
Add functions to convert floats to decimal and decimals to float to fix TypeErrors causes when using ChatBedrock
Co-authored-by: Mayaank Vadlamani <[email protected]>
Co-authored-by: Mayaank Vadlamani <[email protected]>
|
Diffs LGTM. Next step is to get it past pipeline and for @willydouhard / @tpatel / team to test and approve. |
|
Anything you need from me to progress this @mayaankvad ? |
|
No, I think the changes look good. Now it needs @willydouhard / teams approval |
|
Seems like mypy is failing @munday-tech |
|
Are you able to make this fix @munday-tech? |
|
Will get it done asap |
|
@willydouhard @mayaankvad should be good now. |
dokterbob
added
backend
|
Any updates on this one? Looking forward to this being merged |
|
Looks ok to me. |
There was a problem hiding this comment.
Thanks!
I'm waiting for @willydouhard to approve #1288 and #1292 so we can start unit testing data layers.
Awaiting that, I'd love to have unit tests, doc strings and (if possible) types on your functions. If you're able to, please merge the aforementioned branches into yours and implement the unit tests for the functions you just implemented.
Thanks!
| @@ -60,17 +61,49 @@ def __init__( | |||
| def _get_current_timestamp(self) -> str: | |||
| return datetime.now().isoformat() + "Z" | |||
|
|
|||
| def _convert_floats_to_decimal(self, obj): | |||
There was a problem hiding this comment.
Could you please add type hints here so that we can use type checking to ensure that what we think this is doing is actually what it's doing?
There was a problem hiding this comment.
And a docstring, if possible.
|
|
||
| return obj | ||
|
|
||
| def _convert_decimal_to_floats(self, obj): |
There was a problem hiding this comment.
Type hints here as well please. 🙏🏼
There was a problem hiding this comment.
And a docstring, if possible.
dosubot
bot
added
the
size:M
|
I am waiting for this one to be merged |
|
Also waiting on this to be merged - would someone be able to add the required changes so it can be done soon please? |
|
any news about this? |
When using AWS Bedrock,
_update_itemthrows a TypeError as AWS Bedrock returns floats in its response. Dynamodb requires floats to be provided asDecimal. The reverse can also occur if you callget_threadfrom anywhere in code, asDecimalis not JSON serializable.The issue can be seen here #1116
I have added two new functions within
DynamoDBDataLaterthat converts floats to decimals and decimals to floats, calling each function from_update_itemandget_threadrespectively. This change resolves the TypeErrors.