-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
### Summary of Changes Made: #1271
Open
sergeypanin1994
wants to merge
663
commits into
ChainSafe:main
Choose a base branch
from
sergeypanin1994:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sample Updates Added contract call and private key sign/send to the UnsortedSample.cs file. Removed some magic strings and changed them to input parameters in UnsortedSample.cs. Updated tests. * Auto-duplicate Package Samples * Update ContractSendBehaviour.cs * Auto-duplicate Package Samples * Test case Updated test case to use a constant instead of a magic number --------- Co-authored-by: sneakzttv <[email protected]>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * wc integration working * signing/transacting implemented * switched QrCoder with ZXing for generating QrCode Images * chain selection working * main thread dispatcher simplified and WalletConnectModal.cs login error fix * updated scripts path and added remove extra dll before moving to package lib * more path updates and refactor to support testing * Auto-duplicate Package Samples * made some lint changes * more lint fixes * even more lint fixes * disconnect and logout implemented * Changes Made + chain selection reverted/fetched from project config + wallet disconnected if application exits mid run + disconnect method for wallet now async * Auto-duplicate Package Samples * sign typed data checkpoint * sign typed data implemented with Wallet Connect * reverted unwanted changes * error fixes - SceneIndexer.cs doesn't double up scenes - WalletConnectUnity.cs error fix on trust wallet * sign typed data successful * Auto-duplicate Package Samples * Requested Changes Made + WebPageWallet refactored into WalletConnectWallet + Small refactors and renames based on requested PR changes * Auto-duplicate Package Samples * fix path on publish-to-unity-package.bat * wallet model refactor * Auto-duplicate Package Samples * More requested changes made + moved WCLogger to src and used ILogWriter to pass logs * Auto-duplicate Package Samples * requested changes, method order * Auto-duplicate Package Samples * lint fix * updated Logout based on requested changes * Auto-duplicate Package Samples * android build fix * Android Wallet Linking Implemented * Auto-duplicate Package Samples * WalletConnectWallet split into WalletConnectSigner, this is a prelude to separation between ISigner and ITransactionExecutor * Auto-duplicate Package Samples * Changes Made + Added IOS implementation + refactored Unity specific implementations except [preserve] + implemented redirect to wallet option for mobile on Login * Auto-duplicate Package Samples * Lint fix * refactored WalletConnectSigner.cs with optimizations and removed comments * Changes Made + WalletConnectTransactionExecutor Implemented + WC transaction Models and Methods implemented + small fixes and refactors to Web3Accessor and Login * Moved/Refactored UnityEngine.dll from ChainSafe.Gaming.WalletConnect.csproj and used link.xml for preserving types * replaced preserved type with namespace * Auto-duplicate Package Samples * Passing transaction tests * requested changes made * Auto-duplicate Package Samples * made more requested changes * Auto-duplicate Package Samples * signTransaction implemented * Auto-duplicate Package Samples * checkpoint: working android save session * remember me implemented for IOS * Auto-duplicate Package Samples * Refactored a new Service IWalletConnectProvider and move connecting and request out if WalletConnectSigner * removed redundant check * Auto-duplicate Package Samples * more edits opening wallet * Desktop redirecting and linking Implemented * lint fix * removed unnecessary/unused field * Auto-duplicate Package Samples * deeplink uri building fix * checkpoint * bash script files fix ## added a directory check * uptdae scripts * remove scripts merge conflicts * checkpoint * Changes Made + updated wallet connect to v2.1.1 for better Pairing topic and session matching + Renames for WalletConnectProvider based on requested changes * checkpoint * samples added and test duplicate GH action * syntax fix * removed with branch from checkout in duplicate_samples.yml * syntax fix attempt 0 * syntax fix attempt 1 * syntax fix attempt 2 * syntax fix attempt 3 * syntax fix attempt 4 * syntax fix attempt 5 * syntax fix attempt 6 * syntax fix attempt 7 * syntax fix attempt 8 * syntax fix attempt 9 * syntax fix attempt 10 * give permission to run bash script * variable path for version implemented * removed path agnostic implementation * path updates * more path updates * more path changes * more path changes * git add path changes * git add path changes * script updated and tested locally * git add path updates * changed GITHUB_WORKSPACE to github.workspace * more git add path updates * more git add path updates, tested locally * more git add path updates, tested locally * echo ls test * more git add path updates * more git add path updates * added github.workspace to path prefixes * echos and path changes * path updates * echos updated * removed echos and adding web3auth samples * small path updates * updated paths * reverted back to old implementation with variable version support and samples duplicate * path issue fix * web3 auth duplication added * check and create directory * polished CI action and removed duplicate-sample.sh * Changes Made - Added Scene Indexer for Web3 Auth and refactored SceneIndexer - Tested Login with Existing Wallet * Updated web3auth values * refactor and cleanup * testing CI refactor into loop * path substitution fix * path substitution fix * added echos for debugging * added echos for debugging * loop path fix * more path changes * more path updates, hopefully last * even more path updates, gotta work now * even more path updates, must work now * changed trigger from on push to on PR to main, it worked * MiscTests logs updated. * updated mint721 test response * Replaced path strings on CI with repository environment variables * commit path update * moved git config and add into duplicate step * moved git email env variable to duplicate step * added branch checkout * git change * to . * path change to git add * moved commit and push into duplicate step and updated git add path * echo ls copied files * more path updates * git add path update * small git add path update * always try commit * var declaration and ls log moved out of loop * logs added * env variable correct reference * more env var ref fix * syntax fix * log env var * changed env. ref to vars. * updated source copy path * Auto-duplicate Packages Samples * Wallet Dropdown in ExistingWalletLogin now only lists wallets available for current platform. * Auto-duplicate Packages Samples * lint fix * fixed missing namespace issue * Auto-duplicate Packages Samples * small nonce and send transaction bug fix * fixed WebGL login issue * Auto-duplicate Packages Samples --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Peter Kalambet <[email protected]>
* Mint/Transfer 1155 fix * Auto-duplicate Packages Samples --------- Co-authored-by: sneakzttv <[email protected]>
* Fixed iOS not working Had to make sure that the entire walletconnect methods are there since Unity REALLY likes to strip down a lot of code 😄 * Removing unnecessary metas and externaldependency manager.
* Cherry picked * Added refrerences * Cherry picked DTO files * Added config * Auto-duplicate Package Samples * Connecting to unity buttons * Auto-duplicate Package Samples * Function triggering * Trying to get call data to be accepted * Refactored to contract style * No idea how to get logic in to unity * Saved unity files * Finally referenced in the game * Attempting to init packages * Pushing for support * ambiguous method compile error and MultiCall already bound runtime error fixed * ProjectConfig returning bool * Works without multicall again * Calls are successful, return decode, not so much * Results returned as expected * Fixed merge, scripts still broken * Auto-duplicate Package Samples * retrigger checks * Updated comments * rebuilt & removed file again * Auto-duplicate Package Samples * Rebuilt * Lint fix * Rebuilt --------- Co-authored-by: RyRy79261 <[email protected]> Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Peter Kalambet <[email protected]>
* Lootbox namespace change * Auto-duplicate Packages Samples * Update Login.cs * Auto-duplicate Packages Samples --------- Co-authored-by: sneakzttv <[email protected]>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * wc integration working * signing/transacting implemented * checkpoint * checkpoint * checkpoint * checkpoint * checkpoint * switched QrCoder with ZXing for generating QrCode Images * chain selection working * main thread dispatcher simplified and WalletConnectModal.cs login error fix * updated scripts path and added remove extra dll before moving to package lib * more path updates and refactor to support testing * Auto-duplicate Package Samples * made some lint changes * more lint fixes * even more lint fixes * disconnect and logout implemented * Changes Made + chain selection reverted/fetched from project config + wallet disconnected if application exits mid run + disconnect method for wallet now async * Auto-duplicate Package Samples * sign typed data checkpoint * sign typed data implemented with Wallet Connect * reverted unwanted changes * error fixes - SceneIndexer.cs doesn't double up scenes - WalletConnectUnity.cs error fix on trust wallet * sign typed data successful * Auto-duplicate Package Samples * Requested Changes Made + WebPageWallet refactored into WalletConnectWallet + Small refactors and renames based on requested PR changes * Auto-duplicate Package Samples * fix path on publish-to-unity-package.bat * wallet model refactor * Auto-duplicate Package Samples * More requested changes made + moved WCLogger to src and used ILogWriter to pass logs * Auto-duplicate Package Samples * requested changes, method order * Auto-duplicate Package Samples * lint fix * updated Logout based on requested changes * Auto-duplicate Package Samples * android build fix * Android Wallet Linking Implemented * Auto-duplicate Package Samples * WalletConnectWallet split into WalletConnectSigner, this is a prelude to separation between ISigner and ITransactionExecutor * Auto-duplicate Package Samples * Changes Made + Added IOS implementation + refactored Unity specific implementations except [preserve] + implemented redirect to wallet option for mobile on Login * Auto-duplicate Package Samples * Lint fix * refactored WalletConnectSigner.cs with optimizations and removed comments * Changes Made + WalletConnectTransactionExecutor Implemented + WC transaction Models and Methods implemented + small fixes and refactors to Web3Accessor and Login * Moved/Refactored UnityEngine.dll from ChainSafe.Gaming.WalletConnect.csproj and used link.xml for preserving types * replaced preserved type with namespace * Auto-duplicate Package Samples * Passing transaction tests * requested changes made * Auto-duplicate Package Samples * made more requested changes * Auto-duplicate Package Samples * signTransaction implemented * Auto-duplicate Package Samples * checkpoint: working android save session * remember me implemented for IOS * Auto-duplicate Package Samples * Refactored a new Service IWalletConnectProvider and move connecting and request out if WalletConnectSigner * removed redundant check * Auto-duplicate Package Samples * more edits opening wallet * Desktop redirecting and linking Implemented * lint fix * removed unnecessary/unused field * Auto-duplicate Package Samples * deeplink uri building fix * checkpoint * bash script files fix ## added a directory check * uptdae scripts * remove scripts merge conflicts * checkpoint * Changes Made + updated wallet connect to v2.1.1 for better Pairing topic and session matching + Renames for WalletConnectProvider based on requested changes * checkpoint * samples added and test duplicate GH action * syntax fix * removed with branch from checkout in duplicate_samples.yml * syntax fix attempt 0 * syntax fix attempt 1 * syntax fix attempt 2 * syntax fix attempt 3 * syntax fix attempt 4 * syntax fix attempt 5 * syntax fix attempt 6 * syntax fix attempt 7 * syntax fix attempt 8 * syntax fix attempt 9 * syntax fix attempt 10 * give permission to run bash script * variable path for version implemented * removed path agnostic implementation * path updates * more path updates * more path changes * more path changes * git add path changes * git add path changes * script updated and tested locally * git add path updates * changed GITHUB_WORKSPACE to github.workspace * more git add path updates * more git add path updates, tested locally * more git add path updates, tested locally * echo ls test * more git add path updates * more git add path updates * added github.workspace to path prefixes * echos and path changes * path updates * echos updated * removed echos and adding web3auth samples * small path updates * updated paths * reverted back to old implementation with variable version support and samples duplicate * path issue fix * web3 auth duplication added * check and create directory * polished CI action and removed duplicate-sample.sh * Changes Made - Added Scene Indexer for Web3 Auth and refactored SceneIndexer - Tested Login with Existing Wallet * Updated web3auth values * refactor and cleanup * testing CI refactor into loop * path substitution fix * path substitution fix * added echos for debugging * added echos for debugging * loop path fix * more path changes * more path updates, hopefully last * even more path updates, gotta work now * even more path updates, must work now * changed trigger from on push to on PR to main, it worked * MiscTests logs updated. * updated mint721 test response * Replaced path strings on CI with repository environment variables * commit path update * moved git config and add into duplicate step * moved git email env variable to duplicate step * added branch checkout * git change * to . * path change to git add * moved commit and push into duplicate step and updated git add path * echo ls copied files * more path updates * git add path update * small git add path update * always try commit * var declaration and ls log moved out of loop * logs added * env variable correct reference * more env var ref fix * syntax fix * log env var * changed env. ref to vars. * updated source copy path * Auto-duplicate Packages Samples * Wallet Dropdown in ExistingWalletLogin now only lists wallets available for current platform. * Auto-duplicate Packages Samples * lint fix * checkpoint * CI chain/execution order implemented and ready for testing * checkpoint * reverted scripts * workflow triggers updated * Trigger publish on push * separated scripts for publishing and moving files to unity package * reverted scripts directory * updated publish action with better optimized workflow * added dotnet restore before publish * moved publish after remove of obj and bin folders * DLL list echo * publish moved back to it's own step and echo formatting added * added copied DLLs echo and removed rm commands since we use a dependency list * copy replaced with move and added more debug echos * better logs * replaced mv/move back to cp/copy * Published Solution Dependencies to Package Libraries as DLLs * run unity tests on push * try and run tests from project * reverted removal of json.net from link.xml * publish new dependencies with an updated link.xml * Published Solution Dependencies to Package Libraries as DLLs * run unity tests on push * run Unity tests on workflow run completed * added branch ref for commit * dll revert --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: Peter Kalambet <[email protected]>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * small revert to login scene load changes and lootboxes sample duplicate added to CI * Auto-duplicate Packages Samples * Goerli check modified/optimized to be easily replaced with sepolia or other chain * Auto-duplicate Packages Samples * Logo.psd file in sprites removed * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <[email protected]>
…ually by labeling PR `ready-to-merge` and/or ready_for_review (PR out of draft) (ChainSafe#710) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * auto commit on PR then run tests manually on labeling with ready-to-merge * trigger checks when PR is out of draft and ready for review too * reverted auto commit actions triggers to workflow call and added a new workflow for making auto commits This is done to avoid a head ref error when trying to make two pushes simultaneously * new workflow for auto commiting * small typo fix
improve bug report template Co-authored-by: Ryan Noble <[email protected]>
* Fixed debug script * Corrected directory * Re-ran scripts * Lootboxes Sample Fix [Merge Second] (ChainSafe#704) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * small revert to login scene load changes and lootboxes sample duplicate added to CI * Auto-duplicate Packages Samples * Goerli check modified/optimized to be easily replaced with sepolia or other chain * Auto-duplicate Packages Samples * Logo.psd file in sprites removed * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <[email protected]> * CI updates [Merge Third] - auto commits on PR then trigger checks manually by labeling PR `ready-to-merge` and/or ready_for_review (PR out of draft) (ChainSafe#710) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * auto commit on PR then run tests manually on labeling with ready-to-merge * trigger checks when PR is out of draft and ready for review too * reverted auto commit actions triggers to workflow call and added a new workflow for making auto commits This is done to avoid a head ref error when trying to make two pushes simultaneously * new workflow for auto commiting * small typo fix * Merged main & rebuilt * Published Solution Dependencies to Package Libraries as DLLs * Update scripts/debug-publish-to-unity-package.bat * Fixed --------- Co-authored-by: robGG1997 <[email protected]> Co-authored-by: robGG1997 <[email protected]> Co-authored-by: RyRy79261 <[email protected]>
* Technical debt collection Fixing some issues RE: ChainSafe#680 * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * revert revert * Update ChainlinkLootboxSampleLauncher.cs * Auto-duplicate Packages Samples * Update SampleBehaviour.cs * Auto-duplicate Packages Samples --------- Co-authored-by: sneakzttv <[email protected]>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * Changes made + dlls ignored again in .gitignore for packages since we now use CI to generate them + Delete WC storage file if session isn't being restored + Save files closer to project when Application.isEditor for convenience * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * reverted unwanted changes back to main * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <[email protected]>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * checkpoint * added overload with different typed tokenId parameter * reverted type cast for batchOwnerOf * small optimization changes * Auto-duplicate Packages Samples * tokenId type now BigInteger * added overload implementation for 1155 * fix for loading SampleImportNftTexture scene * Auto-duplicate Packages Samples --------- Co-authored-by: robGG1997 <[email protected]>
* Organizing calls * Auto-duplicate Packages Samples * Changes * Auto-duplicate Packages Samples * Update Erc20.cs * Erc721 * Auto-duplicate Packages Samples * 1155 calls 1155 calls * Auto-duplicate Packages Samples * Test fixes Test fixes * Evm & gelato scripts * Scene Scene * Fix tests * Cleanup Cleanup * fix * ECDSA calls ECDSA calls * multicall multicall * multicall multicall * Auto-duplicate Packages Samples * Update SampleMain.unity * Auto-duplicate Packages Samples * Texture request Texture request * Auto-duplicate Packages Samples * Update EvmCalls.cs * Auto-duplicate Packages Samples * Cleanup * Auto-duplicate Packages Samples * Fix tests Fix tests * Auto-duplicate Packages Samples * Fitting the typecast overload fix from Rob in Fitting the typecast overload fix from Rob in * Auto-duplicate Packages Samples * static classes static classes * Auto-duplicate Packages Samples * Fix image Fix image * Auto-duplicate Packages Samples * Gelato disable fix Gelato disable fix * Auto-duplicate Packages Samples * Update GelatoDisableContent.cs * custom token fix custom token fix * Auto-duplicate Packages Samples * evm fix evm fix * Auto-duplicate Packages Samples * Fix for multicall not working. * Auto-duplicate Packages Samples * Fixes Fixes * Auto-duplicate Packages Samples --------- Co-authored-by: sneakzttv <[email protected]> Co-authored-by: Nikola Garabandic <[email protected]> Co-authored-by: kantagara <[email protected]>
* Updated & modified with env updates * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Updated to 2.0.2 * Fixing build not working. Will make a PR On their end as well. * Deleted unnecessary files --------- Co-authored-by: RyRy79261 <[email protected]> Co-authored-by: Nikola Garabandic <[email protected]>
* tests tests * almost all passing almost all passing * Duplicates removed * organizing * Cleanup * cleanup * Cleanup Cleanup * ecdsa ecdsa * Update SampleBehaviour.cs * Cleanup Cleanup * cleanup cleanup * cleanup cleanup * Update SampleMain.unity * Auto-duplicate Packages Samples * Update ChainlinkLootboxSampleLauncher.cs * Auto-duplicate Packages Samples * Update Erc721Tests.cs * Update Chains.cs * Published Solution Dependencies to Package Libraries as DLLs * Update Erc721Tests.cs * Update EvmTests.cs * Update Erc721.cs * update templates update templates * gas limit fixed gas limit fixed * Auto-duplicate Packages Samples * update update * ownerOf ownerOf * Auto-duplicate Packages Samples * owner of batch working * Auto-duplicate Packages Samples * tests * Auto-duplicate Packages Samples * Update Erc1155Tests.cs * tests fixed tests fixed * Auto-duplicate Packages Samples * Update SampleMain.unity * Auto-duplicate Packages Samples * Remove tests Remove tests * Gelato fix Gelato fix * Auto-duplicate Packages Samples * Update SampleLogin.unity * Auto-duplicate Packages Samples * allerc prep allerc prep * Auto-duplicate Packages Samples --------- Co-authored-by: sneakzttv <[email protected]>
Slightly expanded issue template.
* Wallet Exception Wallet Exception * Webgl template check * Published Solution Dependencies to Package Libraries as DLLs * all erc model * Auto-duplicate Packages Samples * complete complete * Auto-duplicate Packages Samples * remove all nft calls remove all nft calls * Auto-duplicate Packages Samples --------- Co-authored-by: sneakzttv <[email protected]> Co-authored-by: Juan Manuel Spoleti <[email protected]>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * setup for IOS build based WC's feedback * added custom websocket implementation * refactor and cleanup * moved web socket as plugin in packages * fixed ws destroy error * reuse connection builder after a logout * ignore generated data files in sample project * removed some unwanted changes and ignored files * removed editor folder from assets and added docs for connection builder in WalletConnectConfig.cs * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * transfer erc 1155 test now passing * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <[email protected]>
* Variables * Auto-duplicate Packages Samples * Template fix Template fix * Published Solution Dependencies to Package Libraries as DLLs * cleanup cleanup * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Update WebGLTemplateSync.cs * Update ServerSettings.cs * Update Erc721Calls.cs * Auto-duplicate Packages Samples * Update Erc721Calls.cs * Update Erc721Calls.cs * Auto-duplicate Packages Samples --------- Co-authored-by: sneakzttv <[email protected]> Co-authored-by: Juan Manuel Spoleti <[email protected]> Co-authored-by: juans-chainsafe <[email protected]>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * Disposing of WC instances done properly * Published Solution Dependencies to Package Libraries as DLLs * reverted merge changes * Published Solution Dependencies to Package Libraries as DLLs * file sharing error possible fix * Published Solution Dependencies to Package Libraries as DLLs * compile error fixes * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * lint fix * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * transfer erc721 hash updated to sepolia --------- Co-authored-by: robGG1997 <[email protected]>
…ges and Web3Auth (ChainSafe#743) * Force the analytics version to 2.5 so that we always get proper version always closes ChainSafe#740 * Analytics are up to 2.5.1 * Added analytics to gelato usage as well as when someone tries to login with web3 auth This one closes ChainSafe#741 * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Fixed errors * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Added EventName so that we don't abuse RPC name * Published Solution Dependencies to Package Libraries as DLLs * Added PackageName to all the analytics we're sending out. * Running a linter * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: kantagara <[email protected]>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * added meta files and disabled publish dlls workflow
* label PR at the end of extra commits * workflow ref changed for testing * trigger condition fixed * try labeler with GitHub token * maybe with deploy key * check on sync triggers * push trigger working now cleaned up for PR * checks only trigger if PR is ready for review or if it's labeled ready-to-merge * env reference fixed * pre job needs check_commit * added name for pre job
…hainSafe#1205) * Fixing the issue with Web3auth not sending transactions with web3auth wallet gui being disabled * Sync Dependencies [skip ci] * Sync Dependencies - Auto Commit --------- Co-authored-by: kantagara <[email protected]> Co-authored-by: Robel Getnet Geremew <[email protected]> Co-authored-by: rob1997 <[email protected]>
new CI path not showing up in required checks in branch protection rule, this could fix it (renamed to old path)
…ChainSafe#1212) * Added bool for event polling to not enfroce people to use websockets. Updated rider plugin. Made Multicall not throw exception if the network doesn't support multicalls. * Duplicated Samples [skip ci] * Sync Dependencies - Auto Commit * SampleMain reverted to the original setting. * Duplicated Samples [skip ci] * Sync Dependencies - Auto Commit --------- Co-authored-by: kantagara <[email protected]>
* documented checks added for PRs * condition checks improved * better log for failure * check existing labels * PR checks updated * update trigger * fixed a bug that would've made dev push perpetually when it's eventually merged to main
* anvil working/integrated but tests still failing * working sample tests * some cleanup and refactor * checkpoint * checkpoint * moved some dependencies down * fixed async issue * Gelato tests * documentation and cleanup * updated workflow to use foundry * submodules update on checkout * trigger on push * log exceptions for initialize * dependencies * 172.17.0.1 * allowing http * dependable dependencies and verbose connection error exception * added --host 0.0.0.0 to anvil * reverted dependencies and push trigger * start and use anvil when in windows * remove pdb meta files * added events service adapter to Web3Unity_Tests.prefab * resolve conflict * merge fixed * small edit * requested changes made * Duplicated Samples [skip ci] * Sync Dependencies - Auto Commit --------- Co-authored-by: rob1997 <[email protected]> Co-authored-by: Nikola Garabandic <[email protected]>
* ExecutionOrderAttribute implemented for ILifecycleParticipants in LifecycleHandler * added docs * apprently C# interfaces hold default data now 🤯 * requested changes made * Sync Dependencies - Auto Commit --------- Co-authored-by: rob1997 <[email protected]>
* we now also generate .meta files * added meta_file_template * CI flow change for PR to main * fixed a mistake * conditional check updated * Sync Dependencies - Auto Commit --------- Co-authored-by: rob1997 <[email protected]>
* changed checkout ref to target and added base input * test run * workflow file ref changed * change the base branch since main and dev are upto date * added some logs for debugging * more logs * check with correct inputs * logs and added fetch just in case * cutting my losses and trying a third party action * skip ci added * skip CI inputs added * remove required from skip_ci input * apparently $ runs commands in bash * maybe pipe it * cutting my loses again * trying some stuff * trying something from stackoverflow * small edits * smaller edits * bash is so weird * message formatting * input options implemented * typo fix * more typo fixes :facepalm * reverted testing refs * typo fix * checking regular git commands if they work * logs and fetch * log latest commit * changed checkout branch at step removed branch log * log last commit command replaced * log status * checkout at base branch * added git branch to find base branch * trying more combinations * updated dev PR checks to trigger with multiple labels * setup now uses a proper command line parser * updated workflows with new command line parameters * updated local scripts with new arguments * text formatting * updated release argument * -r is also already in use, --deploy * typo fix * arguments fix for sync verb * fixed skip ci option * changed setup ref * typo fix * fixing some parsing issues * added a . at the end of path because git isn't finding path * logging and trying something I found on git * more logs and messing with directory * fixed path * allow unrelated histories * empty trigger * more logging * typo fixed * trial without exclusion logic * reverted changes * added git log on checkout * reverted log * added some merge options * merging the other way * reverted reverse merging * check if history is related * checking target's last commits * more logs * one line logging * GH actions is running one commit branches :faceplam * what happens if I force pull do I get all the commits? * TIL GitHub only fetches one commit from head by default * revert back testing changes * added back config input for sync dependencies * ci shouldn't be skipped on dev (for extra commits)
Replaced the outdated Twitter URL (https://twitter.com/) with the updated x.com format (https://x.com/) to align with the platform's rebranding.
- Replaced "repo" with "repository" for clarity. - Changed "you have to install Xcode" to "you must install Xcode" for stronger language. - Improved phrasing in the instructions for Linux distribution and Unity website. - Corrected phrasing in the .NET installation instructions using Homebrew. - Minor updates to provide clearer instructions for adding new modules and linking to external resources.
- Corrected "Singer" to "Signer" in relevant sections. - Fixed grammatical errors: "it look like this" → "it looks like this", "it's dependencies" → "its dependencies". - Removed unnecessary apostrophe in "that's' not swappable". - Adjusted phrasing of the migration process description: "Migration might not be the best word" → "Migration may not be the best word".
Thanks a bunch @sergeypanin1994 ! |
boorich
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
rob1997
force-pushed
the
main
branch
6 times, most recently
from
January 21, 2025 16:16
eb5502a
to
e731948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes Made:
Modular Approach:
Contribution Guide:
Twitter URL Update: