Fix Transaction Types #48
Conversation
…gin-zksync into smart-account
There was a problem hiding this comment.
It seems like there are a lot of formatting-only changes in this PR. Why were those changes made? Would it be possible to revert those so that it's easier to understand the relevant changes to the code? Alternatively, could you provide some additional information in the PR description to help understand what relevant changes were made?
There was a problem hiding this comment.
Is this PR meant to address #37? The ZKsyncWallet.deposit method is still using an ad hoc type (as are the other wallet transactions)...
|
other than what dan said, i think there were other changes made like if u can list out the changes that would be great, but if the scope of this was to fix transaction types it looks like you've changed it :) |
There was a problem hiding this comment.
I still see the use of lots of ad hoc transaction parameters in adapters.ts, for instance, deposit, estimateGasDeposit, getFullRequiredDepositFee, requestExecute, estimateGasRequestExecute, getRequestExecuteAllowanceParams, getRequestExecuteContractMethod, getRequestExecuteTx and withdraw. Would it be possible to create one or more transaction types that are exposed to developers and can be used as parameters for these methods?
No description provided.