Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make eip712 independent #43

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

avkos
Copy link
Collaborator

@avkos avkos commented Aug 25, 2024

Issue #42

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just small points at test.

test/local/provider.test.ts Outdated Show resolved Hide resolved
expect(w1.getAddress()).not.toBe(w2.getAddress());
});

it('should be different wallet when use the same provider', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is a duplicate was it meant to be something else?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. thank you it will be test for smart-account

@avkos avkos merged commit e61a442 into main Aug 27, 2024
2 checks passed
@avkos avkos deleted the ok/42-Eip712-signer-for-differents-wallets branch August 27, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants