Get transaction details (request) #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysu
reviewed
Jan 17, 2025
krzysu
reviewed
Jan 17, 2025
krzysu
reviewed
Jan 17, 2025
krzysu
reviewed
Jan 17, 2025
packages/circle-demo-webapp/app/components/TransactionDetails/TransactionDetails.tsx
Outdated
Show resolved
Hide resolved
krzysu
reviewed
Jan 17, 2025
krzysu
reviewed
Jan 17, 2025
...ebapp/app/routes/transactions.$walletId/components/TransactionDetails/TransactionDetails.tsx
Outdated
Show resolved
Hide resolved
krzysu
reviewed
Jan 17, 2025
...ebapp/app/routes/transactions.$walletId/components/TransactionDetails/TransactionDetails.tsx
Outdated
Show resolved
Hide resolved
krzysu
reviewed
Jan 17, 2025
packages/circle-demo-webapp/app/routes/transactions.$walletId/route.tsx
Outdated
Show resolved
Hide resolved
krzysu
requested changes
Jan 17, 2025
sztok7
reviewed
Jan 17, 2025
packages/circle-demo-webapp/app/components/TransactionDetails/TransactionDetails.tsx
Outdated
Show resolved
Hide resolved
...ebapp/app/routes/transactions.$walletId/components/TransactionDetails/TransactionDetails.tsx
Outdated
Show resolved
Hide resolved
...ebapp/app/routes/transactions.$walletId/components/TransactionDetails/TransactionDetails.tsx
Outdated
Show resolved
Hide resolved
...ebapp/app/routes/transactions.$walletId/components/TransactionDetails/TransactionDetails.tsx
Outdated
Show resolved
Hide resolved
packages/circle-demo-webapp/app/routes/transactions.$walletId/route.tsx
Outdated
Show resolved
Hide resolved
...ebapp/app/routes/transactions.$walletId/components/TransactionDetails/TransactionDetails.tsx
Outdated
Show resolved
Hide resolved
krzysu
reviewed
Jan 21, 2025
| await callFetch('/api/createWallet', args); | ||
| return true; | ||
| } catch (err) { | ||
| setError(err as Error); |
There was a problem hiding this comment.
this looks good, thanks for taking care of it 👍
krzysu
reviewed
Jan 21, 2025
| sdk.getWalletTokenBalance({ | ||
| id, | ||
| includeAll: true, | ||
| }), | ||
| sdk.getWallet({ id }), | ||
| sdk.listTransactions({ |
There was a problem hiding this comment.
why you don't like getting initial transactions from the server? loading them on the client side slows down the page load and requires you to handle loading and error states.
There was a problem hiding this comment.
we need to add Tokens to the transaction. we already have this functionality in another place. we have two choices:
- use what we have (fast way)
- make a separate helper to fill transactions with tokens
krzysu
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.