fix: update valid voluntary exit check when building block #7376
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
Jan 19, 2025
| @@ -53,7 +53,7 @@ export { | |||
| } from "./cache/effectiveBalanceIncrements.js"; | |||
|
|
|||
| // BeaconChain validation | |||
| export {isValidVoluntaryExit} from "./block/processVoluntaryExit.js"; | |||
| export {isValidVoluntaryExit, isValidVoluntaryExitElectra} from "./block/processVoluntaryExit.js"; | |||
There was a problem hiding this comment.
those should probably just be a single function with the fork check handled inside the function
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nflaig/fix-pending-partial-withdrawals #7376 +/- ##
=======================================================================
Coverage 48.62% 48.62%
=======================================================================
Files 603 603
Lines 40517 40517
Branches 2071 2071
=======================================================================
+ Hits 19700 19701 +1
+ Misses 20779 20778 -1
Partials 38 38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another issue, we might build a block with a invalid voluntary exit since we haven't updated the check when building the block, only in state transition.