-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use stable firefox release in browser tests #7318
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7318 +/- ##
=========================================
Coverage 48.75% 48.75%
=========================================
Files 601 601
Lines 40222 40222
Branches 2061 2061
=========================================
Hits 19609 19609
Misses 20575 20575
Partials 38 38 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
This requires more changes, CI is still failing https://github.com/ChainSafe/lodestar/actions/runs/12416331817/job/34664977579?pr=7318#step:6:64
|
Motivation
Closes #7307
Description
Use stable firefox release in browser tests
Their latest tag seems to refer to nightly builds (works on mac as confirmed by @nazarhussain)
but the specific version is missing for Linux which causes the CI to fail