Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs don't trigger required checks #5118

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 8, 2025

Summary of changes

Changes introduced in this pull request:

  • workaround for required checks for docs as documented in the workflow file,
  • don't trigger expensive jobs on doc workflow changes

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the workaround-required-ci branch 15 times, most recently from 9d6d246 to f7d895f Compare January 8, 2025 14:21
@LesnyRumcajs LesnyRumcajs force-pushed the workaround-required-ci branch from aa3b705 to 91adff8 Compare January 9, 2025 10:11
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review January 9, 2025 10:21
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 9, 2025 10:21
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and elmattic and removed request for a team January 9, 2025 10:21
Copy link
Contributor

@hanabi1224 hanabi1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we merge this branch into #5104 to verify it works before merging it into main.

@LesnyRumcajs
Copy link
Member Author

I'd suggest we merge this branch into #5104 to verify it works before mergeing it.

It won't work. The branch will see that we modified something other than docs, i.e., forest.yml and so it will run regular checks as usual.

@hanabi1224
Copy link
Contributor

It won't work. The branch will see that we modified something other than docs, i.e., forest.yml and so it will run regular checks as usual.

Ah you are right : )

@hanabi1224 hanabi1224 enabled auto-merge January 9, 2025 10:47
@hanabi1224 hanabi1224 added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit e6df30c Jan 9, 2025
44 checks passed
@hanabi1224 hanabi1224 deleted the workaround-required-ci branch January 9, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants