Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Automate Comparison of Checksums for Forest and Lotus Snapshots #2963

Closed

Conversation

jdjaustin
Copy link
Contributor

@jdjaustin jdjaustin commented Jun 9, 2023

Summary of changes

Changes introduced in this pull request:

  • We are already running both Forest and Lotus with the benchmark script, so this PR will extend that script to export a snapshot during the Forest client run and compare the checksum against the downloaded Lotus snapshot's checksum.

Reference issue to close (if applicable)

Closes #2559

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@jdjaustin
Copy link
Contributor Author

jdjaustin commented Jun 15, 2023

@elmattic I haven't been able to get the snapshot export logic to work for Lotus. If you have some time to help troubleshoot, that might be helpful. But no need to spend much time on it; I think I'm just going to work on restoring the --tipset functionality to Forest so we can use that approach.

@jdjaustin
Copy link
Contributor Author

Blocked by #2999

@jdjaustin
Copy link
Contributor Author

Plan to open a new issue in forest-iac after benchmark script is moved and after PR to restore --tipset flag has landed.

@jdjaustin jdjaustin closed this Jul 14, 2023
@jdjaustin jdjaustin deleted the jdjaustin/issue-2559-autocompare-snapshot-checksums branch November 30, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate Comparison of Checksums for Forest and Lotus Snapshots
1 participant