Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks to support a couple of the API v2 features #18

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

adamrogas
Copy link

Added video_copy and audio_copy options to enable transmuxing support.

I also made the input data available to the HTTP post notification as zencoder returns the input data in their response and it was nice having them available from the post back.

Updates to support 1 source file multiple outputs including audio only
jobs for AAC profiles.
changes needed to specify a pass through value on CreateRequest
@ChadBurggraf
Copy link
Owner

These commits look good at first glance, and I'd love to merge them in. However, when I run the test suite with HEAD at be83a40, 8 tests fail.

I haven't looked into the failure in more detail yet, but if you could provide any insight that might be helpful.

@adamrogas
Copy link
Author

Ill go check that out out sorry it was a late night.

-Adam

Sent from my iPhone

On Aug 3, 2013, at 8:05 AM, Chad Burggraf [email protected] wrote:

These commits look good at first glance, and I'd love to merge them in. However, when I run the test suite with HEAD at be83a40, 8 tests fail.

I haven't looked into the failure in more detail yet, but if you could provide any insight that might be helpful.


Reply to this email directly or view it on GitHub.

For some reason zencoder's api does not support versioned calling of the
cancel command.

The other oddity is that List Job's at least from my zencode account is
timing out.
A couple of the methods have been changed to PUT's rather than GET's so
modifications where needed to keep the entire project pointed at V2 of
the API
@adamrogas
Copy link
Author

Sorry about the premature Pull request, There were some changes between V1 and V2 that I had failed to notices primarily the change from GET's to PUT's on a couple of the methods.

Cancel, Integration / Live Mode, Resubmit

Changes then had to be made to reflect the 204 response from the PUT command as a successful command. I added a response property of NoContent that also allows checking on the response.

Finally added two methods to create a job with a passThrough value.

All Tests are passing.

@adamrogas
Copy link
Author

Ping

@adamrogas
Copy link
Author

Any chance to review / commit these changes ?

@ChadBurggraf
Copy link
Owner

This has been merged into api-v2. It would be great if some other folks could try it out before I publish it to master. Moving to the V2 API seems like a big deal to me, but all of the tests are currently passing.

@mbonig
Copy link

mbonig commented Jun 9, 2014

any word on this, I'm very interested in some of the V2 features getting incorporated in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants