Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build separation #188

Merged
merged 44 commits into from
Dec 29, 2023
Merged

Conversation

rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Dec 5, 2023

MERGE AFTER #198

@rakanalh rakanalh force-pushed the feature/CI-separation branch 2 times, most recently from cc148d6 to 6eb30c3 Compare December 6, 2023 16:23
@rakanalh rakanalh closed this Dec 18, 2023
@rakanalh rakanalh deleted the feature/CI-separation branch December 18, 2023 20:34
@rakanalh rakanalh restored the feature/CI-separation branch December 18, 2023 20:35
@rakanalh rakanalh reopened this Dec 18, 2023
@rakanalh rakanalh self-assigned this Dec 18, 2023
@rakanalh rakanalh changed the title Feature/ci separation CI: Build separation Dec 18, 2023
@rakanalh rakanalh marked this pull request as ready for review December 18, 2023 22:04
Copy link

gitguardian bot commented Dec 26, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
9100662 Generic High Entropy Secret 60b7db3 node/service/chain-specs/example.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rakanalh rakanalh changed the base branch from dev to chore/cleanup-ddc-offchain December 26, 2023 16:04
@rakanalh rakanalh force-pushed the feature/CI-separation branch 2 times, most recently from 4ccecbe to 248cb89 Compare December 26, 2023 16:43
@rakanalh rakanalh merged commit b7e4ee1 into chore/cleanup-ddc-offchain Dec 29, 2023
5 checks passed
@rakanalh rakanalh deleted the feature/CI-separation branch December 29, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants