Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mizar Deployment Design doc #188

Open
wants to merge 7 commits into
base: dev-next
Choose a base branch
from
Open

Add Mizar Deployment Design doc #188

wants to merge 7 commits into from

Conversation

Hong-Chang
Copy link
Collaborator

No description provided.

@Hong-Chang Hong-Chang requested review from zasherif and a team as code owners July 15, 2020 19:47
@Hong-Chang Hong-Chang self-assigned this Jul 15, 2020
Copy link
Contributor

@zasherif zasherif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good start. We need to add more details on the deployment environment, CI/CD platforms you plan to use, ...etc. I don't think we will merge this design document right away until we have couple of iterations and initial scripts.

docs/design/deployment_design.md Show resolved Hide resolved
docs/design/deployment_design.md Show resolved Hide resolved

![Simple Endpoint](png/mizar-phase-1.png)

- **Mizar Phase 2**: Mizar is targeting to 2-cluster model. In the model, Mizar is running at a k8s or Arktos cluster, and it provides network functions to another k8s or Arktos cluster through Mizar proxy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "In the model, Mizar..." to: "In this 2-cluster model, Mizar's management plane is running in a separate k8s cluster than Arkos compute cluster. An Arktos cluster will deploy the transit daemon and a Mizar proxy to communicate with the Mizar management plane."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

docs/design/deployment_design.md Outdated Show resolved Hide resolved
docs/design/deployment_design.md Outdated Show resolved Hide resolved
docs/design/deployment_design.md Outdated Show resolved Hide resolved
docs/design/deployment_design.md Outdated Show resolved Hide resolved
docs/design/deployment_design.md Outdated Show resolved Hide resolved
docs/design/deployment_design.md Outdated Show resolved Hide resolved
docs/design/deployment_design.md Show resolved Hide resolved
@Hong-Chang Hong-Chang requested a review from zasherif July 15, 2020 23:40
Copy link
Contributor

@zasherif zasherif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the diagrams, otherwise it lgtm

docs/design/deployment_design.md Show resolved Hide resolved
@Hong-Chang
Copy link
Collaborator Author

That's a good start. We need to add more details on the deployment environment, CI/CD platforms you plan to use, ...etc. I don't think we will merge this design document right away until we have couple of iterations and initial scripts.

I added more content about CI/CD. Original I think CI/CD is another work item but it's good to put CI/CD together with deployment work.

@Hong-Chang Hong-Chang requested a review from zasherif July 17, 2020 18:07
Copy link
Contributor

@zasherif zasherif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/design/deployment_design.md Show resolved Hide resolved
Copy link
Contributor

@phudtran phudtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! I added some minor comments.
Thanks Hong!

docs/design/deployment_design.md Outdated Show resolved Hide resolved
docs/design/deployment_design.md Outdated Show resolved Hide resolved
docs/design/deployment_design.md Outdated Show resolved Hide resolved
docs/design/deployment_design.md Show resolved Hide resolved
docs/design/deployment_design.md Outdated Show resolved Hide resolved
@Hong-Chang Hong-Chang requested a review from phudtran July 21, 2020 18:27
Copy link
Contributor

@phudtran phudtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants