Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more restrictions on VPC ip range #1390

Closed
wants to merge 3 commits into from
Closed

Add more restrictions on VPC ip range #1390

wants to merge 3 commits into from

Conversation

Sindica
Copy link
Collaborator

@Sindica Sindica commented Mar 3, 2022

Fix mizar container creating issue.
#1383

@centaurus-cloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zmn223
You can assign the PR to them by writing /assign @zmn223 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sindica Sindica force-pushed the poc-2022-01-30-TenantVPCFix branch 2 times, most recently from 5d8b724 to 628e3ef Compare March 3, 2022 19:00
@Sindica Sindica requested review from h-w-chen, q131172019 and yb01 March 3, 2022 21:09
@Sindica Sindica added this to the 0.10 milestone Mar 3, 2022
@Sindica Sindica force-pushed the poc-2022-01-30-TenantVPCFix branch from 628e3ef to 616e8fd Compare March 4, 2022 02:06
@Sindica Sindica requested a review from Hong-Chang March 4, 2022 18:37
@Sindica Sindica force-pushed the poc-2022-01-30-TenantVPCFix branch from 616e8fd to 7adf606 Compare March 5, 2022 01:55
Sindica added 2 commits March 5, 2022 02:16
@Sindica
make update
0fd770f
@Sindica
Distinct VPC range, passing VPC start/end from cmd arg for scale out.
c01237a 
This is a workaround for Mizar cniplugin that cannot handle VPC overlap within & across TPs.
@Sindica Sindica force-pushed the poc-2022-01-30-TenantVPCFix branch from 7adf606 to c01237a Compare March 5, 2022 03:07
@Sindica Sindica closed this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-w-chen h-w-chen h-w-chen left review comments

@q131172019 q131172019 Awaiting requested review from q131172019

@yb01 yb01 Awaiting requested review from yb01

@Hong-Chang Hong-Chang Awaiting requested review from Hong-Chang

Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/L
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@Sindica @centaurus-cloud-bot @h-w-chen