Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

[No-Ticket] rename getter related methods and private key with secret key #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AbnerZheng
Copy link
Contributor

@AbnerZheng AbnerZheng commented Dec 15, 2020

Overview

Rename API methods:

balanceOfByAccountHash      -->  getBalanceByAccountHash
balanceOfByPublicKey        -->  getBalanceByPublicKey
deployToJson                -->  getDeployAsJSON
getAccountsDeploys          -->  getAccountDeploys
loadKeyPairFromPrivateFile  -->  getKeyPairFromSecretPEMFile
loadPrivateKeyFromFile      -->  getSecretKeyFromPEMFile
loadPublicKeyFromFile       -->  getPublicKeyFromPEMFile
newHdWallet                 -->  getWalletFromSeed
newKeyPair                  -->  getKeyPair
privateToPublicKey          -->  getPublicKeyFromSecretKey

And also rename private key secret key everywhere.

Which JIRA ticket does this PR relate to?

Add the link here. Create a ticket and link it here if one does not exist.

Complete this checklist before you submit this PR

  • This PR contains no more than 200 lines of code, excluding test code.
  • This PR meets CasperLabs coding standards.
  • If this PR adds a new feature, it includes tests related to this feature.
  • You assigned one person to review this PR.
  • Your GitHub account is linked with our Drone CI system. This is necessary to run tests on this PR.
  • Do not forget to run bors r+ if GitHub policy is not enforced, e.g. when merging into another feature branch. It may be omitted under some circumstances if this PR intentionally assumes that integration tests will fail but will be fixed with the future PRs.

Notes

Optional. Add any notes on caveats, approaches you tried that didn't work, or anything else.

@AbnerZheng AbnerZheng requested a review from zie1ony December 15, 2020 08:39
@AbnerZheng AbnerZheng changed the title [No-Ticket] rename getter related methods. [No-Ticket] rename getter related methods and private key with secret key Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant