AnimatedNumber component with hook wrapping animateValue
#509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- encapsulate animation effects in widgets - wrap around `animateValue` in utils - provide JSDoc documentation - provide TS typings
juandjara
changed the title
animateValue
Pull Request Test Coverage Report for Build 3339056222
💛 - Coveralls |
|
Would you please also add a little line to changelog? |
|
@VictorVelarde all requested changes are ready. Thanks for your quick feedback |
VictorVelarde
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up of the changes proposed in RFC #479 and the discussion originated from PR #504. This PR extracts the new animation component used in comparative widgets that wraps around the
animateValuefunction inutilsfolder.The changes included in this PR are the following:
useAnimatedNumberhook based onanimateValueutil, encapsulating state, refs and effects<AnimatedNumber />component as a simple interface to render the results ofuseAnimatedNumberhook.AnimatedNumberanduseAnimatedNumberAnimatedNumberanduseAnimatedNumberType of change
(choose one and remove the others)
Acceptance
As with other comparative widget PRs, you can use this branch of
carto-react-templateto test the behaviour ofComparativeFormulaWidgetUIandComparativeCategoryWidgetUI. Both widgets have been uptaded with the changes necesary in their respective branches.Basic checklist