-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to peft
from opendelta
for parameter efficient tuning methods
#434
Labels
feature request
New feature or request
Comments
Assignee: @glerzing will be taking a go at this :) |
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
Apr 20, 2023
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
Apr 21, 2023
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
Apr 22, 2023
I'm curious as to the status of this issue/PR |
I'm developing automated tests for it, there should be a PR soon. |
@glerzing look forward it |
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
May 13, 2023
…CarperAI#434) + Collapse reference+learner hydra heads when using LoRa (CarperAI#320)
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
May 13, 2023
…CarperAI#434) + Collapse reference+learner hydra heads when using LoRa (CarperAI#320)
@glerzing when will have a pr? |
It should be ready for PR tomorrow, sorry for the wait. |
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
May 23, 2023
…CarperAI#434) + Collapse reference+learner hydra heads when using LoRa (CarperAI#320)
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
May 23, 2023
…CarperAI#434) + Collapse reference+learner hydra heads when using LoRa (CarperAI#320)
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
May 24, 2023
…CarperAI#434) + Collapse reference+learner hydra heads when using LoRa (CarperAI#320)
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
May 24, 2023
…CarperAI#434) + Collapse reference+learner hydra heads when using LoRa (CarperAI#320)
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
May 24, 2023
…CarperAI#434) + Collapse reference+learner hydra heads when using LoRa (CarperAI#320)
glerzing
added a commit
to glerzing/trlx
that referenced
this issue
May 24, 2023
…CarperAI#434) + Collapse reference+learner hydra heads when using LoRa (CarperAI#320)
jon-tow
added a commit
that referenced
this issue
Jun 23, 2023
* Migrate to peft from opendelta for parameter efficient tuning methods (#434) + Collapse reference+learner hydra heads when using LoRa (#320) * fix from_config * Review corrections * ILQL generate when temperature is 0. * revert: guard against experimental 8-bit loading support * format: run `black` --------- Co-authored-by: jon-tow <[email protected]> Co-authored-by: maxreciprocate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 The feature, motivation, and pitch
Let's migrate to
peft
.Tasks
Doing so will require the following updates:
Replace the
opendelta
setup in theAccelerateBaseTrainer
with apeft
backed setup:trlx/trlx/trainer/accelerate_base_trainer.py
Lines 145 to 155 in 92b68e4
Handle fine-grained layer capturing to only modify the upper trunk layers of hydra architectures as handled below:
trlx/trlx/utils/modeling.py
Lines 414 to 428 in 92b68e4
Motivation
Citing @ethankim00's concerns with
opendelta
:opendelta
import fails due to an unnecessaryturtle
package import. Even if pip installed, users may be required to havesudo
privileges to install the corresponding base graphics packageModuleNotFoundError
caused byturtle
package thunlp/OpenDelta#47peft
library, which has been growing rapidlyopendelta
Alternatives
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: