A0-4006: Unit reconstruction refactor #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure the following happened
|
|
Added a small change, since DAG reconstruction does not actually need unit copies, and it likely won't be the component finally holding them; we will see in the next PRs though. |
woocash2
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconstructing the explicit structure of the Dag from the, somewhat compressed, is now handled by a component named "reconstruction" rather than the cryptic "terminal". Internally it also consists of two separate pieces of logic – reconstructing the explicit hashes of parents and ensuring the order of units being added to the Dag.
This leaves a couple awkward points, which will hopefully be ironed out by further refactors around runway.
A big part of the motivation for this refactor is making the upcoming change to differently defined parents simpler to implement.