A0-4006: Check initial unit control hashes early #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure the following happened
|
timorleph
force-pushed
the
A0-4406-stabim
branch
from
d340f18
to
01956cf
Compare
kostekIV
approved these changes
Feb 28, 2024
woocash2
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control hashes of initial units have to refer to the empty parent set, so their combined hash is actually known a priori and can be checked early. This also changes one test that used to assume a initial unit with a broken hash can be passed into consensus.
The only connection to A0-4006 is that the test in question failed after the refactor, since I didn't want to react to this incongruous situation internally.