A0-1505: terminator back in consensus #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure the following happened
|
This reverts commit 60900ad.
woocash2
force-pushed
the
A0-1505-terminator-back-in-consensus
branch
from
9f4b414 to
3887f33
Compare
kostekIV
approved these changes
Oct 27, 2023
lesniak43
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we've moved
Terminatortotypesas we needed it to be usable byrmcin the new shape. Finally tho, we pushedrmcin a different shape as initially expected, soTerminatordoesn't need to be intypesanymore.A better place for terminator is
consensusas it doesn't exactly fit intypes, and it being moved totypeswas a sort of a compromise.